New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve characteristics organization and naming #211

Merged

taldcroft merged 2 commits into master from characteristics-naming

Dec 25, 2018

Member

taldcroft commented Dec 24, 2018

This improves the consistency of file and module names and does some re-organization of characteristics:

acq is no longer special, subsystem characteristics are characteristics_<sub>
Common characteristics are moved into characteristics.py
Follow the convention that acq, guide, fid always come at the end, e.g. report_guide.py not guide_report.py.

Extras:

Added a test for guide report making to check this PR didn't break it.


          Improve characteristics organization and naming

1bd3494

taldcroft added this to the Matlab - proseco TRR milestone


          Fix docstring copy/paste mistake

e5be490

taldcroft merged commit aae2f7e into master

taldcroft deleted the characteristics-naming branch

December 25, 2018 10:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet