Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor process_include_ids to a common base class #205

Merged
merged 4 commits into from
Dec 23, 2018

Conversation

taldcroft
Copy link
Member

@taldcroft taldcroft commented Dec 19, 2018

This removes the class=0 restriction on included guide stars.

It also refactors acq/guide into a common base method.

Fixes #204.

@jeanconn
Copy link
Contributor

This will probably also break my guide star reporting that somewhat assumed guide stars would be fully contained within the dark current map.

@jeanconn
Copy link
Contributor

And per my comment in the issue, I think thumbs_up would need to be adjusted to at least only count guide stars that are fully in the guide-allowed FOV.

There's the other issue that I don't know if thumbs_up should just be 0 to help identify when the user does something super-weird or if we need another warning interface for the matlab tools (I think right now we're only passing exceptions back).

@taldcroft
Copy link
Member Author

Curses. Your points are well taken, thinking.

@jeanconn
Copy link
Contributor

We've got time on this. I don't think this needs to go out in a bugfix patch now which puts the issue at the Starcheck 13.1 level.

@taldcroft
Copy link
Member Author

I think the 90c7b61 addresses your concerns and that no other code changes would be required. The upshot is a refactor and taking out the CLASS filtering. And better test coverage.

@taldcroft taldcroft added this to the Starcheck 13.1 milestone Dec 19, 2018
@jeanconn
Copy link
Contributor

I haven't gone back to see which edges those are.

@taldcroft
Copy link
Member Author

The edges had matched your original test, but were not the ones you probably wanted. I think 7c486c3 should be fine now, as it replicates the spatial test in getting initial candidates.

@taldcroft taldcroft merged commit f366e5d into master Dec 23, 2018
@taldcroft taldcroft deleted the include-refactor branch December 23, 2018 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants