Guide reporting #197
Guide reporting #197
Conversation
MAG_ACA is exactly the same as mag so this is redundant. MAG_ACA_ERR does provide different information from mag_err, but it isn't clear how this is useful since MAG_ACA_ERR is known to have limitations which get fixed up in mag_err.
|
I think this is ready to go. It could still use a plot of the star field and catalog, but that can be added in a separate PR. |
| @@ -371,7 +371,7 @@ def __init__(self, data=None, **kwargs): | |||
| # Make printed table look nicer. This is defined in advance | |||
| # and will be applied the first time the table is represented. | |||
| self._default_formats = {'p_acq': '.3f'} | |||
| for name in ('yang', 'zang', 'row', 'col', 'mag', 'maxmag', 'mag_err', 'color'): | |||
| for name in ('yang', 'zang', 'row', 'col', 'mag', 'maxmag', 'mag_err', 'color', 'COLOR1'): | |||
There was a problem hiding this comment.
I think I want ASPQ1 too
| # Plot a box showing the 8x8 image boundaries | ||
| x = row0 + drow / 2 - 4 | ||
| y = col0 + dcol / 2 - 4 | ||
| patch = patches.Rectangle((x, y), 8, 8, edgecolor='y', facecolor='none', lw=1) |
There was a problem hiding this comment.
I was also trying to decide if there was value in trying to plot some indicator of the edge of the useable fov, though that's probably just applicable for the force-included stars that concerned me earlier.
|
|
||
| # First plot: star spoilers | ||
| ax = fig.add_subplot(1, 2, 1) | ||
| plot_spoilers(guide, cand_guides, ax) |
There was a problem hiding this comment.
Though since this just uses the table of the other candidates to get cand_guides.stars, it would make more sense to just pass cand_guides.stars .
There was a problem hiding this comment.
Doesn't hurt to have the whole thing and makes the API more consistent. These may end up as methods anyway in the next round of refactor that I'm planning.
|
PS I'm working on the validation notebook, so ping me if you end up wanting to work on that. |
| @@ -23,7 +23,7 @@ | |||
| # Do reporting for at-most MAX_CAND candidates | |||
| MAX_CAND = 50 | |||
| COLS = ['id', 'stage', 'forced', | |||
| 'mag', 'mag_err', 'MAG_ACA', 'MAG_ACA_ERR', | |||
| 'mag', 'mag_err', | |||
There was a problem hiding this comment.
MAG_ACA_ERR is used directly in the spoiler tests. I thought it was somewhat useful to have it here because I found myself looking it up for the cases where it is not presently reasonable (bright candidates). But I suppose if the ids are links to the kadi star lookup that's fine.
|
PPS Where are the validation notebooks suppose to live at this point? Not in version control? |
|
Validation notebooks are in /proj/sot/ska/analysis/proseco/www (which is a link). I gave up on version control for these, not seeing the value added (but including the I'm not planning to work on the guide validation notebook. |
|
On MAG_ACA_ERR, fair enough. Reverted in f09e3a2. The main thing is that in the meantime we put in this cut on mag_err for color=1.5 stars and will probably want something for bright stars, so MAG_ACA_ERR is really not the right thing. We probably need a |
|
And I see this is captured in #192, will update that a bit. |
|
Merging to just get this into master. Further improvements or tweaks are likely. |
No description provided.