Use P2 for calc_p_safe and optimization metric #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been thinking about acq catalog optimization and realizing (after the acq model update issues) that the current
p_safedefinition (as probability of 1 or fewer stars) is dominated by the few brightest stars and the "safety" stars can have little or no influence.Changing to "probability of 2 or fewer stars" makes the algorithm dig one star deeper. It also has the good feature of optimizing for exactly the metric that is used in catalog evaluation.
The regression diffs introduced here are not that substantial and in line with typical churn from other changes.