Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove aiprops report.
This removes the generation of a table html page of the AIPROPS entries for science observations. We weren't using this anyway and removing it here removes another sybase dependence from our tools.
This PR also includes an unrelated bug fix noticed when writing out reports - the template included the slew error that we no longer have in starcheck, and just removing it from the template seems fine.
This removes a dependence on the old sybase-based aiprops table.
Interface impacts
Removes a small html file of the aiprops data.
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
The test_write_report has a functional test to confirm that a report for a few obsids can be written without error, but it does not keep the output. I used that test setup to make a report for a few obsids:
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/mica/pr-302/16/16000/
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/mica/pr-302/28/28790/
https://icxc.cfa.harvard.edu/aspect/test_review_outputs/mica/pr-302/44/44001/