-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a get_aca_images method for mica l0 #301
base: master
Are you sure you want to change the base?
Conversation
@jeanconn - this is substantially revised, so please have a look. |
|
||
# Combine all slot data into one output table and sort by time and slot | ||
out = vstack(slot_data_list) | ||
out.sort(keys=["TIME", "IMGNUM"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With all of the discussion about END_INTEG_TIME and TIME in chandra_aca, I'm wondering in passing if we should use END_INTEG_TIME instead of TIME as the more unambiguous quantity for this kind of thing (the sort).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you are just sorting, I think it's the same.
For joins and for searches I always use VCDU frame these days.
Description
Add a
get_aca_images()
method to micaaca_l0
. This new function replicates the outputs ofchandra_aca.maude_decom.get_aca_images()
exactly, apart from providing additional column outputs documented in the function docstring.This would be a supporting method to replace "get_mica_images" in the current sot/chandra_aca#174 . The idea is to provide a method to get something similar to
maude_decom.get_aca_images
for the purposes of getting background-subtracted images.Interface impacts
This adds two columns
PIXTLM
andBGDTYP
to the output ofget_slot_data
. For L0 data that hasn't been reprocessed since DS10.8.3 and doesn't have those columns in the source data FITS file, these are filled withORIG
andFLAT
, respectively.Testing
Testing done with a sparse local L0 archive with the required data to pass tests.
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
No functional testing.