in tests_acq/guide: close temp file before unlinking it #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In tests_acq/guide: close temp file before unlinking it.
From the docs:
Since the file is open, it should be close before unlinking. Otherwise, one gets this error on windows:
I know we would not use this on windows most probably, but still...
Interface impacts
Testing
Unit tests
Independent check of unit tests by [REVIEWER NAME]
Functional tests
After this PR, the test do not fail at this point in Windows. They fail later because I test on a VM, and the symbolic links in
mica/archive/obspar
are not supported in the VM