Use has_internet to skip planet tests requiring network #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taldcroft
reviewed
Mar 16, 2022
chandra_aca/tests/test_planets.py
Outdated
| @@ -105,6 +110,7 @@ def test_planet_positions_array(): | |||
| assert np.all(sphere_dist(ra, dec, ra2, dec2) * 3600 < 1.0) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif('not HAS_INTERNET', reason='Requires network access') | |||
There was a problem hiding this comment.
Modern preferred style is to write this as
@pytest.mark.skipif(not HAS_INTERNET, reason='Requires network access')
This should work as long as you provide a reason.
There was a problem hiding this comment.
Thanks! I think you told me this already, but when I searched sot for skipif tests I wasn't sure which was the canonical example (and I couldn't remember that the only change was the string to not-string handling...).
taldcroft
approved these changes
Mar 16, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Use has_internet to skip planet tests requiring network (for GRETA).
Testing