Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

table-generator: add sorting feature to columns #130

Closed
cheshire opened this issue Apr 9, 2016 · 1 comment · Fixed by #477
Closed

table-generator: add sorting feature to columns #130

cheshire opened this issue Apr 9, 2016 · 1 comment · Fixed by #477
Labels
enhancement HTML table

Comments

@cheshire
Copy link
Member

cheshire commented Apr 9, 2016

I think this feature would be really beneficial.
I know there's a FF plugin, but I (and many others) use Chrome, and existing table-sorting plugins for Chrome do not play nicely with Benchexec.
@PhilippWendler PhilippWendler changed the title Benchexec table generator: add sorting feature to columns table-generator: add sorting feature to columns Apr 10, 2016
@PhilippWendler
Copy link
Member

Note that since you added the floating header you need to click on a cell in the table body for sorting if you use a browser plugin, clicking on a cell in the table header won't work anymore, not even in Firefox. Do the existing plugins still not work with our tables even if you do this?

I do not have time to work on this, unfortunately, but if somebody sends a pull request, I would merge it. Before it is worked on this feature, however, there should be a discussion of how to design the feature, i.e., where to integrate the UI for it.

@PhilippWendler PhilippWendler mentioned this issue Apr 28, 2017
Closed
@PhilippWendler PhilippWendler mentioned this issue Nov 1, 2019
Merged
PhilippWendler added a commit that referenced this issue Nov 2, 2019
@PhilippWendler
Rewrite of HTML tables with React (#477)
d20b13b 
This provides a complete rewrite of the HTML tables that `table-generator` produces. Instead of statically creating a HTML `<table>`, we now insert the data as JSON and use [React](https://reactjs.org/) to render a table dynamically. Furthermore, all the spaghetti code for interactive features like plots is now completely replaced by a proper architecture using React components, and there exists infrastructure to test this.

Some new features like better row filters and improvements have also been added based on a user study. But the main advantage is that it is now possible to open large tables in browsers without long waiting periods.

The studies and the rewrite were done by @bschor and a report about this is available as her [Bachelor's thesis](https://www.sosy-lab.org/research/bsc/2019.Bschor.Modern_Architecture_and_Improved_UI_for_Tables_of_BenchExec.pdf).

Users who whish to continue using the old tables can pass `--static-table` to `table-generator`, but we expect this to be removed in BenchExec 3.0.

Fixes #130 (sorting added)
Fixes #423 (summary tab with only header and footer of table added)
Closes #123 (all Javascript is now bundled in the HTML file)
Closes #195 (all Javascript is now bundled in the HTML file)
Closes #214 (filtering is now longer in an overlay, and much faster anyway)
Closes #237 ([react-table](https://www.npmjs.com/package/react-table) is used)
Closes #296 (main table has only small header, full header is shown on summary tab)
Closes #297 (main table has only small header, full header is shown on summary tab)
Closes #375 (no longer applicable)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement HTML table
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite of HTML tables with React sosy-lab/benchexec
2 participants
@cheshire @PhilippWendler