[Plugin] Collect exact filesizes in add_dir_listing #3758
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add_dir_listing
method in #3664 hid exact filesizes in "ls -l
" like outputs in favour of human readable output. That has two drawbacks:3.1K
can mean3075
or3174
bytes and the difference can matter for some well known files with well known default sizes.sos
tool should be data collectio tool rather than interpreting them. So let replace human readable filesize by exact one.Resolves: #3758
Please place an 'X' inside each '[]' to confirm you adhere to our Contributor Guidelines