[IWJ-17] Migrate to vue-cli3 #9
Conversation
oimou
force-pushed
the
feature/IWJ-17-vue-cli-3
branch
from
eade82e to
89263dc
Compare
in reference to package.json which is created by vue-cli with "with sass" option
because electron-builder tries to rebuild native module, while iroha-lib doesn't have a corresponding binary yet.
in order to load iroha-util.js as is. According to the comment below, transform-runtime adds `import` to each file and makes it unable to use `module.exports`. webpack/webpack#4039 (comment)
oimou
force-pushed
the
feature/IWJ-17-vue-cli-3
branch
from
bba435b to
9f6e64d
Compare
| @@ -1,24 +1,20 @@ | |||
| import Vue from 'vue' | |||
| import axios from 'axios' | |||
| import '@babel/polyfill' | |||
There was a problem hiding this comment.
In order to use Promise.prototype.finally. This will be replaced with individual requires by Babel. https://github.com/babel/babel/tree/master/packages/babel-preset-env#usebuiltins-entry
public/index.html
Outdated
| </head> | ||
| <body> | ||
| <noscript> | ||
| <strong>We're sorry but myproject3 doesn't work properly without JavaScript enabled. Please enable it to continue.</strong> |
package.json
Outdated
| @@ -10,99 +10,95 @@ | |||
| "license": null, | |||
There was a problem hiding this comment.
(wrong line, but)
"productName": "Iroha Wallet" ?
this way it will have a correct name in window title/applications folder.
There was a problem hiding this comment.
Also, maybe its time to set version to 0.1.0 :D
package.json
Outdated
| @@ -10,99 +10,95 @@ | |||
| "license": null, | |||
There was a problem hiding this comment.
Also, maybe its time to set version to 0.1.0 :D
package.json
Outdated
| "webpack-merge": "^4.1.0" | ||
| "@babel/polyfill": "^7.0.0-beta.48", | ||
| "@babel/preset-env": "^7.0.0-beta.47", | ||
| "@vue/cli-plugin-babel": "^3.0.0-beta.10", |
There was a problem hiding this comment.
maybe its time to update all of them to beta.15? :3
LICENSE
Outdated
| same "printed page" as the copyright notice for easier | ||
| identification within third-party archives. | ||
|
|
||
| Copyright [yyyy] [name of copyright owner] |
There was a problem hiding this comment.
I guess we should keep License :) (And fill those blanks with actual year and company name).
This reverts commit 84e8764.
Ticket
https://soramitsu.atlassian.net/browse/IWJ-17
Description
How to check
yarnto install new dependencies.yarn rebuildto rebuild native modulesyarn serve:electronyarn build:electronScreenshot
I tested it with mac, node v10.3.0
For debuggability, "Version" menu shows a commit hash which the app was built from.
