Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IWJ-7] Add WalletsPage #3

Merged
merged 7 commits into from
Apr 25, 2018
Merged

Conversation

oimou
Copy link
Contributor

@oimou oimou commented Apr 20, 2018

Ticket

https://soramitsu.atlassian.net/browse/IWJ-7

Description

Create wallets menu.

Using Dynamic Route Matching, each wallet page obtains wallet data (name and amount for now) by walletId passed as a routing parameter like /dashboard/wallets-page/wallet-1 and render it.

I guessed that the process to fetch wallet data by walletId would be done with some API call in the future, so I put a dummy fetch method fetchWalletByWalletId for now.

How to check

  1. yarn dev to open the app.
  2. Login and go to wallets page. Selecting a wallet shows the wallet data in the right pane.

@oimou oimou changed the title [WIP][IWJ-7] Add WalletsPage [IWJ-7] Add WalletsPage Apr 24, 2018
@oimou oimou requested review from stinger112 and laSinteZ April 24, 2018 06:33
Copy link
Contributor

@laSinteZ laSinteZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I open wallets page, I want the 1 wallet to be selected (So I don't need to click). Please do it + 1 comment and you can merge

text-decoration: none;
color: #7e7e7e;
background: #9d9d9d;
border: 1px solid #aaa;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove right border 1px solid white , so it looks like this :)
screen shot 2018-04-24 at 11 31 54

@oimou oimou merged commit e771c04 into develop Apr 25, 2018
@oimou oimou deleted the feature/IWJ-7-create-wallets-menu branch June 1, 2018 05:39
@oimou oimou mentioned this pull request Jun 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants