[HOTFIX/#25] 속성 파일 인식 불가 이슈 해결 및 외부 파일 주입 방식 적용 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- 의미 전달을 위해 이름에 `OAuth` 키워드를 추가함으로서 쓰이는 범위를 명시했습니다. - 부족하게 정의되어 있는 `playground` 에 대한 내용을 `external.yaml`에 반영했습니다.
… Bean 등록 제거 - 사용되지 않는 `AuthProperty` 클래스를 삭제하고 이에 대해 등록 Config 파일에서도 제거했습니다.
`-Dspring.config.additional-location` 명령 옵션 추가를 통해 볼륨 마운트로 주입되는 외부 파일을 인식할 수 있도록 했습니다.
5 tasks
|
2 tasks
sung-silver
approved these changes
Dec 7, 2024
| @@ -73,18 +73,17 @@ private FormBody createTokenRequestFormBody(final String code) { | |||
| private String createClientSecret() { | |||
| Date now = new Date(); | |||
| PrivateKey privateKey = | |||
| KeyFileUtil.getPrivateKey(appleProperty.apple().key().path()) | |||
| KeyFileUtil.getPrivateKey(appleOAuthProperty.key().path()) | |||
| .orElseThrow(() -> new ClientRequestException(FAIL_READ_APPLE_PRIVATE_KEY_FILE)); | |||
|
|
|||
| return Jwts.builder() // 토큰 생성 로직은 tokenProvider? 근데 얘는 parse는 없음 | |||
There was a problem hiding this comment.
저의.. 고민의 흔적을 안지웠네요 나중에 지우겠습니다 ㅋㅋㅋ ㅜ
Comment on lines
-98
to
-113
|
|
||
| @Bean | ||
| public CorsConfigurationSource corsConfigurationSource() { | ||
| CorsConfiguration configuration = new CorsConfiguration(); | ||
|
|
||
| configuration.addAllowedOrigin(authProperty.client().url()); | ||
| configuration.addAllowedHeader(ALL); | ||
| configuration.addAllowedMethod(ALL); | ||
| configuration.setAllowCredentials(true); | ||
|
|
||
| UrlBasedCorsConfigurationSource source = new UrlBasedCorsConfigurationSource(); | ||
|
|
||
| source.registerCorsConfiguration(PATTERN_ALL, configuration); | ||
|
|
||
| return source; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🚀
Work Description ✏️
PR Point 📸