Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature/#1049] Schedule 화면에 api를 연결합니다. #1050

Merged
merged 8 commits into from
Feb 15, 2025

Conversation

chattymin
Copy link
Member

@chattymin chattymin commented Feb 8, 2025

closed #1049

What is this issue?

  • api 연결
  • 애니메이션 연결
  • navigation은 연결하지 않았습니다. 추후 main과 연결할 때 할 예정입니다.
  • 적당히 미적지근해진 발등

Reference

scheduleWithApi.mp4

@chattymin chattymin self-assigned this Feb 8, 2025
@chattymin chattymin requested a review from a team as a code owner February 8, 2025 12:44
Copy link

height bot commented Feb 8, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Comment on lines 121 to 126
item {
VerticalDividerWithCircle(Color.Unspecified)
VerticalDividerWithCircle(
circleColor = Color.Unspecified,
height = 200.dp
)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이걸 추가한 이유가 있을까요?

Comment on lines +27 to +33
type: String,
isRecentSchedule: Boolean = false,
) {
val (event, containerColor, textColor) = remember {
when (type) {
"SEMINAR" -> Triple("세미나", Orange400.copy(alpha = 0.2f), Orange400)
else -> Triple("행사", Blue400.copy(alpha = 0.2f), Blue400)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"SEMINAR"와 같은 것들 강타입으로 강제할 수 있을까요

Copy link
Member

@l2hyunwoo l2hyunwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오케이!

@chattymin chattymin merged commit 31028fd into feature/app-home Feb 15, 2025
@chattymin chattymin deleted the feature/app-home-#1049 branch February 15, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants