pytest_plugin: disable flood protection for example tests #2630
+2
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For quite a while, we've had three tests from the `rand` plugin that
take several seconds each. I had a Sopelunk with the Git version [1] of
`pytest-profiling` [2] and discovered that about 98% of the time spent
on the five tests selected by `pytest -k rand.py` was in `time.sleep()`.
Drilling down, I saw that was being called from `bot.say()`, which led
pretty quickly to the real culprit: Flood protection.
There's no server to flood during tests, so we can just turn that
protection off. With this change, those five tests from `rand` went from
about 12 seconds on my test system down to about 0.25 sec.
[1]: The last actual release of `pytest-profiling` is from 2019, and it
doesn't work on modern Python. (I started analyzing this under
Python 3.13, while verifying fixes for new warnings there.) All of
the necessary updates already exist in the Git repo, though; they
just haven't published a new release in five years.
[2]: https://github.com/man-group/pytest-plugins/tree/master/pytest-profiling
dgw
added
Build
Bugfix
|
Super ironic that the CI run for this PR had some of the longest job times this repo's ever seen… 3/6 jobs went over 2m, where normally they are all done in about 90 seconds. Still, I promise this made local tests on my machine a lot faster. GHA hosted runner performance might be too inconsistent to draw any conclusions from, especially based on only a single run. Current After Again, can't draw too much of a conclusion from single runs, but the difference is definitely noticeable. |
Exirel
approved these changes
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patch feels almost too simple to work, but it does.
For quite a while, we've had three tests from the
randplugin that take several seconds each. I had a Sopelunk with the Git version ofpytest-profiling(because they haven't released in about 5 years and the last package is broken on modern Pythons) and discovered that about 98% of the time spent on the five tests selected bypytest -k rand.pywas intime.sleep().Drilling down, I saw that was being called from
bot.say(), which led pretty quickly to the real culprit: Flood protection.There's no server to flood during tests, so we can just turn that protection off. With this change, those five tests from
randwent from ~12 seconds on my test system down to about 0.25 sec.Checklist
make qa(runsmake lintandmake test)