GHA: Update/fix actions #2592
Merged
GHA: Update/fix actions #2592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both of these actions were using deprecated Node runtimes and generating warnings in our CI logs. Oh, and they'd also eventually stop working entirely when the deprecated runtime is removed. That's probably the best reason to update them.
See earlier commit updating CI workflow deps for commentary.
This action doesn't provide a rolling 'v1' tag due to security concerns. The same security concerns exist when using a tag, so we use a specific (signed) commit's SHA.
CodeQL action v2 is deprecated, and will end support in December 2024. https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/
|
Noticed that https://github.blog/changelog/2024-01-12-code-scanning-deprecation-of-codeql-action-v2/ had slipped by. Better to catch it now than having the analysis suddenly break in December. |
Exirel
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
actions/checkoutandactions/setup-pythonwere using deprecated Node runtimes and generating warnings in our CI logs. Oh, and they'd also eventually stop working entirely when the deprecated runtime is removed. That's probably the best reason to update them.I also discovered that there is no
v1tag forpypa/gh-action-pypi-publish, so our existingpypi.ymlworkflow from #2328 wouldn't ever work. Because tags can be easily changed if a malicious someone gains access to the action's repository, the release action is pinned to a specific, verified, commit's SHA.Checklist
make qa(runsmake lintandmake test)ci.ymlworkflow by PR checks, and if the checkout & setup-python actions work there we can assume the same new versions will also work in thepypi.ymlworkflow.pypi.ymlworkflow but that's no change (it was already untested), and we'll have a chance to test it for real soon enough.