Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia: fix urlparse usage & handle Special: namespace #2575

Merged
merged 2 commits into from
Dec 3, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions sopel/builtins/wikipedia.py
Original file line number Diff line number Diff line change
Expand Up @@ -327,12 +327,22 @@ def mw_image_description(server, image):
def mw_info(bot, trigger, match=None):
"""Retrieves and outputs a snippet of the linked page."""
server = match.group(1)
page_info = urlparse(match.group(2))
article = unquote(page_info.path)
page_info = urlparse(match.group(0))
# in Python 3.9+ this can be str.removeprefix() instead, but we're confident that
# "/wiki/" is at the start of the path anyway since it's part of the pattern
trim_offset = len("/wiki/")
article = unquote(page_info.path)[trim_offset:]
section = unquote(page_info.fragment)

if article.startswith("Special:"):
# The MediaWiki query API does not include pages in the Special:
# namespace, so there's no point bothering when we know this will error
LOGGER.debug("Ignoring page in Special: namespace")
return False

if section:
if section.startswith('cite_note-'): # Don't bother trying to retrieve a snippet when cite-note is linked
if section.startswith('cite_note-'):
# Don't bother trying to retrieve a section snippet if cite-note is linked
say_snippet(bot, trigger, server, article, show_url=False)
elif section.startswith('/media'):
# gh2316: media fragments are usually images; try to get an image description
Expand Down Expand Up @@ -363,6 +373,11 @@ def wikipedia(bot, trigger):
if not query:
bot.reply('What do you want me to look up?')
return plugin.NOLIMIT

if query.startswith("Special:"):
bot.reply("Sorry, the MediaWiki API doesn't support querying the Special: namespace.")
return False

server = lang + '.wikipedia.org'
query = mw_search(server, query, 1)
if not query:
Expand Down