Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coretasks: fix SASL EXTERNAL without password set #2561

Merged
merged 1 commit into from
Nov 25, 2023
Merged

coretasks: fix SASL EXTERNAL without password set #2561

merged 1 commit into from
Nov 25, 2023

Conversation

half-duplex
Copy link
Member

Description

Fix #2560, now separate and with test (verified to fail without patch)

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make lint and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Nov 12, 2023
@half-duplex half-duplex added this to the 8.0.0 milestone Nov 12, 2023
Exirel
Exirel requested changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, looking good. Smaller modifications requested for the test, and a couple of nitpicks.

test/coretasks/test_coretasks_sasl.py Outdated Show resolved Hide resolved
test/coretasks/test_coretasks_sasl.py Outdated Show resolved Hide resolved
test/coretasks/test_coretasks_sasl.py Outdated Show resolved Hide resolved
test/coretasks/test_coretasks_sasl.py Outdated Show resolved Hide resolved
Exirel
Exirel requested changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last requirement on tests, to make sure we can't just throw messages in any order, no matter the situation.

test/coretasks/test_coretasks_sasl.py Outdated Show resolved Hide resolved
test/coretasks/test_coretasks_sasl.py Outdated Show resolved Hide resolved
Exirel
Exirel approved these changes Nov 25, 2023
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you!

@dgw dgw merged commit 7b03d9c into sopel-irc:master Nov 25, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw left review comments

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

SASL EXTERNAL incorrectly requires a password to be set
3 participants
@half-duplex @dgw @Exirel