Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate: Make help more helpful about language :hints #2453

Merged
merged 1 commit into from
Jun 4, 2023

Conversation

half-duplex
Copy link
Member

Description

Don't make me PM the bot to not even be reminded how .tr wants language hints.

You may now discuss whether we should reorder the examples, have one or two hints, why we don't have a @plugin.help("Something less docstring-ish here"), etc. in comments.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@half-duplex half-duplex added this to the 8.0.0 milestone May 14, 2023
@dgw dgw requested a review from a team May 14, 2023 03:10
@dgw dgw force-pushed the translate-help branch from b2dbef3 to 8aea6e0 Compare May 28, 2023 08:39
@dgw dgw requested a review from Exirel May 28, 2023 08:42
@dgw
Copy link
Member

dgw commented May 28, 2023

Re-requested review because I changed the patch to include both :hint and non-hint versions of the command, which served a double purpose in forcing GH to update the base branch for a new CI run (since it was stubbornly refusing to create a fresh merge for running tests after #2455 was merged).

Help output is now:

<dgw> .help tr
<SopelTest> dgw: Translates a phrase, with an optional language :hint.
<SopelTest> e.g. .tr mon chien or .tr :en :fr my dog

Optionally, @half-duplex might want to re-amend the commit with a proper signature, but given our (lack of a) project policy re: commit signing, it doesn't actually matter.

Co-authored-by: dgw <dgw@technobabbl.es>
@dgw dgw merged commit 4ea258f into sopel-irc:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants