-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
find: fix flags in pipe-separated substitutions #2447
Conversation
Unescaped `|` was messing up capturing the flags at the end of the line.
One comment that doesn't line up with the others bugs me, and moving that one would make it too close by Python conventions (<2 spaces after EOL), so the only choice is obviously to adjust all the other comments.
I guess the first thing for me to look at tomorrow will be "what's wrong with you, Coveralls?"
|
Status update: Located an issue where several people are discussing the Coveralls error that the CI jobs are running into on this pull request. See lemurheavy/coveralls-public#1708 |
Follow-up in a different thread says a fix has been applied for the Coveralls error: lemurheavy/coveralls-public#1710 (comment) Rerunning the CI checks a few moments ago succeeded (except for having to retry the finalize step again due to a pip error). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you say it works, it works.
Description
Unescaped
|
was messing up capturing the flags at the end of the line.Checklist
make qa
(runsmake quality
andmake test
)Notes
Introduced in #1993, first released in v7.1.0. Should be backported if we make a 7.1.10 release (but I'm still not planning one).