Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

find: fix flags in pipe-separated substitutions #2447

Merged
merged 2 commits into from
May 24, 2023
Merged

find: fix flags in pipe-separated substitutions #2447

merged 2 commits into from
May 24, 2023

Conversation

dgw
Copy link
Member

@dgw dgw commented Apr 29, 2023

Description

Unescaped | was messing up capturing the flags at the end of the line.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

Introduced in #1993, first released in v7.1.0. Should be backported if we make a 7.1.10 release (but I'm still not planning one).

dgw added 2 commits April 29, 2023 00:35
Unescaped `|` was messing up capturing the flags at the end of the line.
One comment that doesn't line up with the others bugs me, and moving
that one would make it too close by Python conventions (<2 spaces after
EOL), so the only choice is obviously to adjust all the other comments.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Apr 29, 2023
@dgw dgw added this to the 8.0.0 milestone Apr 29, 2023
@dgw dgw requested a review from a team April 29, 2023 05:40
@dgw
Copy link
Member Author

dgw commented Apr 29, 2023

I guess the first thing for me to look at tomorrow will be "what's wrong with you, Coveralls?"

Submitting coverage to coveralls.io...
Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs
resubmitting with id None
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/coveralls/api.py", line 290, in submit_report
    response.raise_for_status()
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/requests/models.py", line 1021, in raise_for_status
    raise HTTPError(http_error_msg, response=self)
requests.exceptions.HTTPError: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs

The above exception was the direct cause of the following exception:

Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/coveralls/cli.py", line 95, in main
    result = coverallz.wear()
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/coveralls/api.py", line 257, in wear
    return self.submit_report(json_string)
  File "/opt/hostedtoolcache/Python/3.9.16/x64/lib/python3.9/site-packages/coveralls/api.py", line 293, in submit_report
    raise CoverallsException(
coveralls.exception.CoverallsException: Could not submit coverage: 422 Client Error: Unprocessable Entity for url: https://coveralls.io/api/v1/jobs
Error: Process completed with exit code 1.

@dgw dgw mentioned this pull request Apr 29, 2023
4 tasks
@dgw
Copy link
Member Author

dgw commented Apr 30, 2023

Status update: Located an issue where several people are discussing the Coveralls error that the CI jobs are running into on this pull request. See lemurheavy/coveralls-public#1708

@dgw
Copy link
Member Author

dgw commented May 1, 2023

Follow-up in a different thread says a fix has been applied for the Coveralls error: lemurheavy/coveralls-public#1710 (comment)

Rerunning the CI checks a few moments ago succeeded (except for having to retry the finalize step again due to a pip error).

Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you say it works, it works.

@dgw dgw merged commit bc5b964 into master May 24, 2023
@dgw dgw deleted the find-pipe-flags branch May 24, 2023 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants