safety: logging level tweaks #2420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* failure to delete old malwaredomains file is upgraded to a warning: fixing the problem requires manual intervention * domain list update is now all debug, all the time, except if there is an error (which generates a warning so the bot owner can see if it's repeatedly failed) * cache cleanup being skipped is also debug now; it didn't make sense for "cleanup already running" to be louder than "starting cleanup"
Exirel
requested changes
Mar 13, 2023
Previous status message in the download function has been demoted to debug level, but it's still nice to confirm at startup that an update attempt is being made.
dgw
force-pushed
the
safety-logging-tweaks
branch
from
38eaa59 to
091aa90
Compare
Exirel
approved these changes
Mar 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make qa(runsmake qualityandmake test)Notes
I'm looking specifically at
info()logging calls in light of #2419 and very well might run through all the places where the most common messages I see in logs of the bots I run/admin just to double-check that we're using the INFO level sensibly.