Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remind: skip remind_monitoring() if IRC connection not ready #2351

Merged
merged 1 commit into from
Oct 9, 2022
Merged

remind: skip remind_monitoring() if IRC connection not ready #2351

merged 1 commit into from
Oct 9, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Oct 1, 2022

Description

Past-due reminders could be consumed during startup (and emit an error to the log about the event loop not being started yet).

The documentation for @plugin.interval() has had a warning in it about not assuming that the IRC connection will be available for I don't even know how long, at this point. It's about time core followed its advice.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
remind: skip remind_monitoring() if IRC connection not ready
2c33b35 
Past-due reminders could be consumed during startup (and emit an error
to the log about the EventLoop not being started yet).

The documentation for `@plugin.interval()` has had a warning in it about
not assuming that the IRC connection will be available for I don't even
know how long, at this point. It's about time core followed its advice.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Oct 1, 2022
@dgw dgw added this to the 8.0.0 milestone Oct 1, 2022
@dgw dgw requested a review from a team October 1, 2022 05:19
SnoopJ
SnoopJ approved these changes Oct 7, 2022
View reviewed changes
Copy link
Contributor

@SnoopJ SnoopJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a straightforward change to me 👍

@dgw dgw removed the request for review from a team October 9, 2022 05:47
@dgw
Copy link
Member Author

dgw commented Oct 9, 2022

Order of operations notwithstanding (reviewed first, then added to Rockstars team), @SnoopJeDi's review was supposed to count toward that request I just dismissed.

@dgw dgw merged commit 27dbaf8 into master Oct 9, 2022
@dgw dgw deleted the remind-heisensocket branch October 9, 2022 05:48
@dgw dgw mentioned this pull request Nov 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SnoopJ SnoopJ SnoopJ approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dgw @SnoopJ