Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reqs: allow xmltodict 0.13 #2334

Merged
merged 2 commits into from
Aug 17, 2022
Merged

reqs: allow xmltodict 0.13 #2334

merged 2 commits into from
Aug 17, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Jul 27, 2022

Description

Tin. I tried and tried, but couldn't find any reason not to allow the newer version of xmltodict now that we no longer support Python 2.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

On IRC, @Strykar said this does break something, but I have no idea what (no details). I invite them to post said details here.

@dgw dgw added the Build label Jul 27, 2022
@dgw dgw added this to the 8.0.0 milestone Jul 27, 2022
@dgw dgw requested a review from a team July 27, 2022 00:11
@dgw
Copy link
Member Author

dgw commented Jul 27, 2022 •
edited
Loading

… Coveralls is broken again. Really? 😑

(Edit, next day: It's fixed. CI re-run and passed.)

@Strykar
Copy link

Strykar commented Jul 27, 2022 •
edited by dgw
Loading

Notes

On IRC, @Strykar said this does break something, but I have no idea what (no details). I invite them to post said details here.

Unsure how much this will help, but disabling tests fixes the issue:

Arch PKGBUILD log 
$ namcap PKGBUILD 
$ makepkg -s
==> Making package: sopel 7.1.9-1 (Tue 26 Jul 2022 07:29:08 PM IST)
==> Checking runtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Packages (6) python-maxminddb-2.2.0-4  python-prawcore-2.3.0-3  python-update-checker-0.18.0-5  python-geoip2-4.5.0-1  python-praw-7.6.0-1  python-xmltodict-0.13.0-2

Total Download Size:   0.34 MiB
Total Installed Size:  2.55 MiB

:: Proceed with installation? [Y/n] y
:: Retrieving packages...
 python-maxminddb-2.2.0-4-x86_64                                                                                               26.0 KiB  4.55 KiB/s 00:06 [###############################################################################################] 100%
 python-prawcore-2.3.0-3-any                                                                                                   27.2 KiB  4.75 KiB/s 00:06 [###############################################################################################] 100%
 python-update-checker-0.18.0-5-any                                                                                            13.1 KiB  2.28 KiB/s 00:06 [###############################################################################################] 100%
 python-geoip2-4.5.0-1-any                                                                                                     32.1 KiB  5.39 KiB/s 00:06 [###############################################################################################] 100%
 python-praw-7.6.0-1-any                                                                                                      238.9 KiB  38.9 KiB/s 00:06 [###############################################################################################] 100%
 python-xmltodict-0.13.0-2-any                                                                                                 15.8 KiB  2.57 KiB/s 00:06 [###############################################################################################] 100%
 Total (6/6)                                                                                                                  353.1 KiB  54.7 KiB/s 00:06 [###############################################################################################] 100%
(6/6) checking keys in keyring                                                                                                                            [###############################################################################################] 100%
(6/6) checking package integrity                                                                                                                          [###############################################################################################] 100%
(6/6) loading package files                                                                                                                               [###############################################################################################] 100%
(6/6) checking for file conflicts                                                                                                                         [###############################################################################################] 100%
(6/6) checking available disk space                                                                                                                       [###############################################################################################] 100%
:: Running pre-transaction hooks...
(1/1) Checking Arch News with Informant ...
There are no unread news items
:: Processing package changes...
(1/6) installing python-xmltodict                                                                                                                         [###############################################################################################] 100%
(2/6) installing python-prawcore                                                                                                                          [###############################################################################################] 100%
(3/6) installing python-update-checker                                                                                                                    [###############################################################################################] 100%
(4/6) installing python-praw                                                                                                                              [###############################################################################################] 100%
(5/6) installing python-maxminddb                                                                                                                         [###############################################################################################] 100%
(6/6) installing python-geoip2                                                                                                                            [###############################################################################################] 100%
:: Running post-transaction hooks...
(1/3) Arming ConditionNeedsUpdate...
(2/3) Searching for orphaned packages...
python-geoip2 4.5.0-1
python-praw 7.6.0-1
python-xmltodict 0.13.0-2
(3/3) Syncing file system on /...
==> Checking buildtime dependencies...
==> Installing missing dependencies...
resolving dependencies...
looking for conflicting packages...

Packages (8) python-apipkg-2.1.1-1  python-iniconfig-1.1.1-5  python-pluggy-1.0.0-1  python-py-1.11.0-1  python-pytest-7.1.2-1  python-pytest-runner-5.3.2-1  python-requests-mock-1.9.3-3  python-sphinxcontrib-autoprogram-0.1.7-3

Total Download Size:   0.75 MiB
Total Installed Size:  3.69 MiB

:: Proceed with installation? [Y/n] y
:: Retrieving packages...
 python-apipkg-2.1.1-1-any                                                                                                     12.4 KiB  15.8 KiB/s 00:01 [###############################################################################################] 100%
 python-iniconfig-1.1.1-5-any                                                                                                   9.0 KiB  11.0 KiB/s 00:01 [###############################################################################################] 100%
 python-requests-mock-1.9.3-3-any                                                                                              30.9 KiB  36.9 KiB/s 00:01 [###############################################################################################] 100%
 python-pluggy-1.0.0-1-any                                                                                                     25.4 KiB  29.7 KiB/s 00:01 [###############################################################################################] 100%
 python-sphinxcontrib-autoprogram-0.1.7-3-any                                                                                  16.9 KiB  18.6 KiB/s 00:01 [###############################################################################################] 100%
 python-pytest-runner-5.3.2-1-any                                                                                              12.1 KiB  11.6 KiB/s 00:01 [###############################################################################################] 100%
 python-pytest-7.1.2-1-any                                                                                                    500.3 KiB   396 KiB/s 00:01 [###############################################################################################] 100%
 python-py-1.11.0-1-any                                                                                                       157.0 KiB  52.1 KiB/s 00:03 [###############################################################################################] 100%
 Total (8/8)                                                                                                                  764.1 KiB   232 KiB/s 00:03 [###############################################################################################] 100%
(8/8) checking keys in keyring                                                                                                                            [###############################################################################################] 100%
(8/8) checking package integrity                                                                                                                          [###############################################################################################] 100%
(8/8) loading package files                                                                                                                               [###############################################################################################] 100%
(8/8) checking for file conflicts                                                                                                                         [###############################################################################################] 100%
(8/8) checking available disk space                                                                                                                       [###############################################################################################] 100%
:: Running pre-transaction hooks...
(1/1) Checking Arch News with Informant ...
There are no unread news items
:: Processing package changes...
(1/8) installing python-sphinxcontrib-autoprogram                                                                                                         [###############################################################################################] 100%
(2/8) installing python-iniconfig                                                                                                                         [###############################################################################################] 100%
(3/8) installing python-pluggy                                                                                                                            [###############################################################################################] 100%
(4/8) installing python-apipkg                                                                                                                            [###############################################################################################] 100%
(5/8) installing python-py                                                                                                                                [###############################################################################################] 100%
(6/8) installing python-pytest                                                                                                                            [###############################################################################################] 100%
(7/8) installing python-pytest-runner                                                                                                                     [###############################################################################################] 100%
(8/8) installing python-requests-mock                                                                                                                     [###############################################################################################] 100%
:: Running post-transaction hooks...
(1/3) Arming ConditionNeedsUpdate...
(2/3) Searching for orphaned packages...
python-geoip2 4.5.0-1
python-praw 7.6.0-1
python-pytest-runner 5.3.2-1
python-requests-mock 1.9.3-3
python-sphinxcontrib-autoprogram 0.1.7-3
python-xmltodict 0.13.0-2
(3/3) Syncing file system on /...
==> Retrieving sources...
  -> Downloading sopel-7.1.9.tar.gz...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  471k    0  471k    0     0   469k      0 --:--:--  0:00:01 --:--:-- 12.7M
==> Validating source files with sha512sums...
    sopel-7.1.9.tar.gz ... Passed
==> Extracting sources...
  -> Extracting sopel-7.1.9.tar.gz with bsdtar
==> Starting prepare()...
==> Starting build()...
running build
running build_py
creating build
creating build/lib
creating build/lib/sopel
copying sopel/plugin.py -> build/lib/sopel
copying sopel/__init__.py -> build/lib/sopel
copying sopel/loader.py -> build/lib/sopel
copying sopel/trigger.py -> build/lib/sopel
copying sopel/web.py -> build/lib/sopel
copying sopel/test_tools.py -> build/lib/sopel
copying sopel/coretasks.py -> build/lib/sopel
copying sopel/bot.py -> build/lib/sopel
copying sopel/db.py -> build/lib/sopel
copying sopel/module.py -> build/lib/sopel
copying sopel/logger.py -> build/lib/sopel
copying sopel/formatting.py -> build/lib/sopel
creating build/lib/sopel/tests
copying sopel/tests/__init__.py -> build/lib/sopel/tests
copying sopel/tests/pytest_plugin.py -> build/lib/sopel/tests
copying sopel/tests/factories.py -> build/lib/sopel/tests
copying sopel/tests/mocks.py -> build/lib/sopel/tests
creating build/lib/sopel/irc
copying sopel/irc/__init__.py -> build/lib/sopel/irc
copying sopel/irc/utils.py -> build/lib/sopel/irc
copying sopel/irc/abstract_backends.py -> build/lib/sopel/irc
copying sopel/irc/isupport.py -> build/lib/sopel/irc
copying sopel/irc/backends.py -> build/lib/sopel/irc
creating build/lib/sopel/cli
copying sopel/cli/config.py -> build/lib/sopel/cli
copying sopel/cli/__init__.py -> build/lib/sopel/cli
copying sopel/cli/utils.py -> build/lib/sopel/cli
copying sopel/cli/plugins.py -> build/lib/sopel/cli
copying sopel/cli/run.py -> build/lib/sopel/cli
creating build/lib/sopel/tools
copying sopel/tools/_events.py -> build/lib/sopel/tools
copying sopel/tools/__init__.py -> build/lib/sopel/tools
copying sopel/tools/time.py -> build/lib/sopel/tools
copying sopel/tools/jobs.py -> build/lib/sopel/tools
copying sopel/tools/web.py -> build/lib/sopel/tools
copying sopel/tools/calculation.py -> build/lib/sopel/tools
copying sopel/tools/target.py -> build/lib/sopel/tools
creating build/lib/sopel/modules
copying sopel/modules/wikipedia.py -> build/lib/sopel/modules
copying sopel/modules/search.py -> build/lib/sopel/modules
copying sopel/modules/clock.py -> build/lib/sopel/modules
copying sopel/modules/pronouns.py -> build/lib/sopel/modules
copying sopel/modules/find_updates.py -> build/lib/sopel/modules
copying sopel/modules/choose.py -> build/lib/sopel/modules
copying sopel/modules/version.py -> build/lib/sopel/modules
copying sopel/modules/__init__.py -> build/lib/sopel/modules
copying sopel/modules/announce.py -> build/lib/sopel/modules
copying sopel/modules/xkcd.py -> build/lib/sopel/modules
copying sopel/modules/wiktionary.py -> build/lib/sopel/modules
copying sopel/modules/invite.py -> build/lib/sopel/modules
copying sopel/modules/find.py -> build/lib/sopel/modules
copying sopel/modules/emoticons.py -> build/lib/sopel/modules
copying sopel/modules/translate.py -> build/lib/sopel/modules
copying sopel/modules/lmgtfy.py -> build/lib/sopel/modules
copying sopel/modules/py.py -> build/lib/sopel/modules
copying sopel/modules/remind.py -> build/lib/sopel/modules
copying sopel/modules/countdown.py -> build/lib/sopel/modules
copying sopel/modules/unicode_info.py -> build/lib/sopel/modules
copying sopel/modules/adminchannel.py -> build/lib/sopel/modules
copying sopel/modules/units.py -> build/lib/sopel/modules
copying sopel/modules/currency.py -> build/lib/sopel/modules
copying sopel/modules/ping.py -> build/lib/sopel/modules
copying sopel/modules/rand.py -> build/lib/sopel/modules
copying sopel/modules/ip.py -> build/lib/sopel/modules
copying sopel/modules/admin.py -> build/lib/sopel/modules
copying sopel/modules/dice.py -> build/lib/sopel/modules
copying sopel/modules/isup.py -> build/lib/sopel/modules
copying sopel/modules/meetbot.py -> build/lib/sopel/modules
copying sopel/modules/bugzilla.py -> build/lib/sopel/modules
copying sopel/modules/reddit.py -> build/lib/sopel/modules
copying sopel/modules/safety.py -> build/lib/sopel/modules
copying sopel/modules/uptime.py -> build/lib/sopel/modules
copying sopel/modules/tell.py -> build/lib/sopel/modules
copying sopel/modules/seen.py -> build/lib/sopel/modules
copying sopel/modules/url.py -> build/lib/sopel/modules
copying sopel/modules/calc.py -> build/lib/sopel/modules
copying sopel/modules/reload.py -> build/lib/sopel/modules
copying sopel/modules/help.py -> build/lib/sopel/modules
copying sopel/modules/tld.py -> build/lib/sopel/modules
creating build/lib/sopel/plugins
copying sopel/plugins/handlers.py -> build/lib/sopel/plugins
copying sopel/plugins/__init__.py -> build/lib/sopel/plugins
copying sopel/plugins/jobs.py -> build/lib/sopel/plugins
copying sopel/plugins/exceptions.py -> build/lib/sopel/plugins
copying sopel/plugins/rules.py -> build/lib/sopel/plugins
creating build/lib/sopel/config
copying sopel/config/types.py -> build/lib/sopel/config
copying sopel/config/__init__.py -> build/lib/sopel/config
copying sopel/config/core_section.py -> build/lib/sopel/config
running egg_info
creating sopel.egg-info
writing sopel.egg-info/PKG-INFO
writing dependency_links to sopel.egg-info/dependency_links.txt
writing entry points to sopel.egg-info/entry_points.txt
writing requirements to sopel.egg-info/requires.txt
writing top-level names to sopel.egg-info/top_level.txt
writing manifest file 'sopel.egg-info/SOURCES.txt'
reading manifest file 'sopel.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
adding license file 'COPYING'
writing manifest file 'sopel.egg-info/SOURCES.txt'
make: Entering directory '/home/strykar/sopel/src/sopel-7.1.9/docs'
sphinx-build -b man -d build/doctrees   source build/man
Running Sphinx v5.1.0
making output directory... done
loading intersphinx inventory from https://docs.python.org/3/objects.inv...
loading intersphinx inventory from https://docs.sqlalchemy.org/en/13/objects.inv...
building [mo]: targets for 0 po files that are out of date
building [man]: all manpages
updating environment: [new config] 20 added, 0 changed, 0 removed
reading sources... [100%] trigger                                                                                                                                                                                                                               
looking for now-outdated files... none found
pickling environment... done
checking consistency... done
writing... sopel.1 { } sopel.3 { bot trigger config db api irc } sopel.5 { } done
build succeeded.

The manual pages are in build/man.

Build finished. The manual pages are in build/man.
make: Leaving directory '/home/strykar/sopel/src/sopel-7.1.9/docs'
==> Starting check()...
running pytest
/usr/lib/python3.10/site-packages/setuptools/command/easy_install.py:144: EasyInstallDeprecationWarning: easy_install command is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
/usr/lib/python3.10/site-packages/setuptools/command/install.py:34: SetuptoolsDeprecationWarning: setup.py install is deprecated. Use build and pip and other standards-based tools.
  warnings.warn(
Searching for xmltodict==0.12
Reading https://pypi.org/simple/xmltodict/
/usr/lib/python3.10/site-packages/pkg_resources/__init__.py:122: PkgResourcesDeprecationWarning:  is an invalid version and will not be supported in a future release
  warnings.warn(
Downloading https://files.pythonhosted.org/packages/28/fd/30d5c1d3ac29ce229f6bdc40bbc20b28f716e8b363140c26eff19122d8a5/xmltodict-0.12.0-py2.py3-none-any.whl#sha256=8bbcb45cc982f48b2ca8fe7e7827c5d792f217ecf1792626f808bf41c3b86051
Best match: xmltodict 0.12.0
Processing xmltodict-0.12.0-py2.py3-none-any.whl
Installing xmltodict-0.12.0-py2.py3-none-any.whl to /home/strykar/sopel/src/sopel-7.1.9/.eggs

Installed /home/strykar/sopel/src/sopel-7.1.9/.eggs/xmltodict-0.12.0-py3.10.egg
running egg_info
writing sopel.egg-info/PKG-INFO
writing dependency_links to sopel.egg-info/dependency_links.txt
writing entry points to sopel.egg-info/entry_points.txt
writing requirements to sopel.egg-info/requires.txt
writing top-level names to sopel.egg-info/top_level.txt
reading manifest file 'sopel.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
warning: no previously-included files matching '__pycache__' found under directory '*'
warning: no previously-included files matching '*.py[co]' found under directory '*'
adding license file 'COPYING'
writing manifest file 'sopel.egg-info/SOURCES.txt'
running build_ext
===================================================================================================================== test session starts ======================================================================================================================
platform linux -- Python 3.10.5, pytest-7.1.2, pluggy-1.0.0
rootdir: /home/strykar/sopel/src/sopel-7.1.9, configfile: pytest.ini
plugins: sopel-7.1.9, requests-mock-1.9.3
collected 1155 items                                                                                                                                                                                                                                           

sopel/modules/calc.py .......                                                                                                                                                                                                                            [  0%]
sopel/modules/choose.py .......                                                                                                                                                                                                                          [  1%]
sopel/modules/currency.py EE                                                                                                                                                                                                                             [  1%]
sopel/modules/dice.py ........                                                                                                                                                                                                                           [  2%]
sopel/modules/emoticons.py .....................                                                                                                                                                                                                         [  3%]
sopel/modules/ip.py E                                                                                                                                                                                                                                    [  3%]
sopel/modules/lmgtfy.py ...                                                                                                                                                                                                                              [  4%]
sopel/modules/py.py E                                                                                                                                                                                                                                    [  4%]
sopel/modules/rand.py .....                                                                                                                                                                                                                              [  4%]
sopel/modules/search.py .F...                                                                                                                                                                                                                            [  5%]
sopel/modules/tell.py EE                                                                                                                                                                                                                                 [  5%]
sopel/modules/translate.py EEE                                                                                                                                                                                                                           [  5%]
sopel/modules/unicode_info.py ..                                                                                                                                                                                                                         [  5%]
sopel/modules/units.py .............                                                                                                                                                                                                                     [  6%]
sopel/modules/url.py E                                                                                                                                                                                                                                   [  7%]
sopel/modules/wiktionary.py ..                                                                                                                                                                                                                           [  7%]
test/cli/test_cli_run.py ....................................                                                                                                                                                                                            [ 10%]
test/cli/test_cli_utils.py ......................                                                                                                                                                                                                        [ 12%]
test/config/test_config_types.py ...............................                                                                                                                                                                                         [ 14%]
test/irc/test_irc_abstract_backends.py ...........................                                                                                                                                                                                       [ 17%]
test/irc/test_irc_isupport.py ...............................................................................................                                                                                                                            [ 25%]
test/irc/test_irc_utils.py ....                                                                                                                                                                                                                          [ 25%]
test/modules/test_modules_announce.py .                                                                                                                                                                                                                  [ 25%]
test/modules/test_modules_choose.py ..xxxxxxxx.....................                                                                                                                                                                                      [ 28%]
test/modules/test_modules_find_updates.py .                                                                                                                                                                                                              [ 28%]
test/modules/test_modules_isup.py ...........................                                                                                                                                                                                            [ 30%]
test/modules/test_modules_reddit.py ..............................                                                                                                                                                                                       [ 33%]
test/modules/test_modules_remind.py ...................................................................................................................................................                                                                  [ 46%]
test/modules/test_modules_tell.py .............................                                                                                                                                                                                          [ 48%]
test/modules/test_modules_url.py .....                                                                                                                                                                                                                   [ 49%]
test/plugins/test_plugins_handlers.py ....                                                                                                                                                                                                               [ 49%]
test/plugins/test_plugins_rules.py ...........................................................................................................................................                                                                           [ 61%]
test/test_bot.py .............................................                                                                                                                                                                                           [ 65%]
test/test_config.py .........................                                                                                                                                                                                                            [ 67%]
test/test_coretasks.py ................                                                                                                                                                                                                                  [ 69%]
test/test_db.py ....................                                                                                                                                                                                                                     [ 70%]
test/test_formatting.py ....................................................                                                                                                                                                                             [ 75%]
test/test_irc.py .................................                                                                                                                                                                                                       [ 78%]
test/test_loader.py ................................                                                                                                                                                                                                     [ 80%]
test/test_module.py ......................................                                                                                                                                                                                               [ 84%]
test/test_plugin.py ........................                                                                                                                                                                                                             [ 86%]
test/test_plugins.py .......                                                                                                                                                                                                                             [ 86%]
test/test_regression.py .                                                                                                                                                                                                                                [ 87%]
test/test_tools.py ................                                                                                                                                                                                                                      [ 88%]
test/test_trigger.py ................                                                                                                                                                                                                                    [ 89%]
test/tests/test_tests_mocks.py ..                                                                                                                                                                                                                        [ 89%]
test/tools/test_tools_jobs.py ..............                                                                                                                                                                                                             [ 91%]
test/tools/test_tools_target.py ..............                                                                                                                                                                                                           [ 92%]
test/tools/test_tools_time.py ..........                                                                                                                                                                                                                 [ 93%]
test/tools/test_tools_web.py ..............................................................................                                                                                                                                              [100%]

============================================================================================================================ ERRORS ============================================================================================================================
________________________________________________________________________________________________________ ERROR at setup of test_example_exchange_cmd_0 _________________________________________________________________________________________________________
sopel/modules/currency.py:84: in setup
    bot.config.define_section('currency', CurrencySection)
E   AttributeError: module 'sopel.modules.currency' has no attribute 'config'
________________________________________________________________________________________________________ ERROR at setup of test_example_exchange_cmd_1 _________________________________________________________________________________________________________
sopel/modules/currency.py:84: in setup
    bot.config.define_section('currency', CurrencySection)
E   AttributeError: module 'sopel.modules.currency' has no attribute 'config'
_____________________________________________________________________________________________________________ ERROR at setup of test_example_ip_0 ______________________________________________________________________________________________________________
sopel/modules/ip.py:61: in setup
    bot.config.define_section('ip', GeoipSection)
E   AttributeError: module 'sopel.modules.ip' has no attribute 'config'
_____________________________________________________________________________________________________________ ERROR at setup of test_example_py_0 ______________________________________________________________________________________________________________
sopel/modules/py.py:39: in setup
    bot.config.define_section('py', PySection)
E   AttributeError: module 'sopel.modules.py' has no attribute 'config'
__________________________________________________________________________________________________________ ERROR at setup of test_example_f_remind_0 ___________________________________________________________________________________________________________
sopel/modules/tell.py:96: in setup
    bot.config.define_section('tell', TellSection)
E   AttributeError: module 'sopel.modules.tell' has no attribute 'config'
__________________________________________________________________________________________________________ ERROR at setup of test_example_f_remind_1 ___________________________________________________________________________________________________________
sopel/modules/tell.py:96: in setup
    bot.config.define_section('tell', TellSection)
E   AttributeError: module 'sopel.modules.tell' has no attribute 'config'
_____________________________________________________________________________________________________________ ERROR at setup of test_example_tr2_0 _____________________________________________________________________________________________________________
sopel/modules/translate.py:31: in setup
    if 'mangle_lines' not in bot.memory:
E   AttributeError: module 'sopel.modules.translate' has no attribute 'memory'
_____________________________________________________________________________________________________________ ERROR at setup of test_example_tr2_1 _____________________________________________________________________________________________________________
sopel/modules/translate.py:31: in setup
    if 'mangle_lines' not in bot.memory:
E   AttributeError: module 'sopel.modules.translate' has no attribute 'memory'
_____________________________________________________________________________________________________________ ERROR at setup of test_example_tr2_2 _____________________________________________________________________________________________________________
sopel/modules/translate.py:31: in setup
    if 'mangle_lines' not in bot.memory:
E   AttributeError: module 'sopel.modules.translate' has no attribute 'memory'
________________________________________________________________________________________________________ ERROR at setup of test_example_title_command_0 ________________________________________________________________________________________________________
sopel/modules/url.py:117: in setup
    bot.config.define_section('url', UrlSection)
E   AttributeError: module 'sopel.modules.url' has no attribute 'config'
=========================================================================================================================== FAILURES ===========================================================================================================================
_____________________________________________________________________________________________________________________ test_example_duck_1 ______________________________________________________________________________________________________________________
sopel/tests/pytest_plugin.py:142: in test
    raise AssertionError(message)
E   AssertionError: Output does not match the regex:
E   Pattern: https?:\/\/grandorder\.wiki\/C%C3%BA_Chulainn.*
E   Output: https://grandorder.wiki/Cu_Chulainn_(Alter)
======================================================================================================================= warnings summary =======================================================================================================================
sopel/plugin.py:1380
  /home/strykar/sopel/src/sopel-7.1.9/sopel/plugin.py:1380: PytestUnknownMarkWarning: Unknown pytest.mark.vcr - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/stable/how-to/mark.html
    test = pytest.mark.vcr(test)

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=================================================================================================================== short test summary info ====================================================================================================================
FAILED sopel/modules/search.py::test_example_duck_1 - AssertionError: Output does not match the regex:
ERROR sopel/modules/currency.py::test_example_exchange_cmd_0 - AttributeError: module 'sopel.modules.currency' has no attribute 'config'
ERROR sopel/modules/currency.py::test_example_exchange_cmd_1 - AttributeError: module 'sopel.modules.currency' has no attribute 'config'
ERROR sopel/modules/ip.py::test_example_ip_0 - AttributeError: module 'sopel.modules.ip' has no attribute 'config'
ERROR sopel/modules/py.py::test_example_py_0 - AttributeError: module 'sopel.modules.py' has no attribute 'config'
ERROR sopel/modules/tell.py::test_example_f_remind_0 - AttributeError: module 'sopel.modules.tell' has no attribute 'config'
ERROR sopel/modules/tell.py::test_example_f_remind_1 - AttributeError: module 'sopel.modules.tell' has no attribute 'config'
ERROR sopel/modules/translate.py::test_example_tr2_0 - AttributeError: module 'sopel.modules.translate' has no attribute 'memory'
ERROR sopel/modules/translate.py::test_example_tr2_1 - AttributeError: module 'sopel.modules.translate' has no attribute 'memory'
ERROR sopel/modules/translate.py::test_example_tr2_2 - AttributeError: module 'sopel.modules.translate' has no attribute 'memory'
ERROR sopel/modules/url.py::test_example_title_command_0 - AttributeError: module 'sopel.modules.url' has no attribute 'config'
=============================================================================================== 1 failed, 1136 passed, 8 xfailed, 1 warning, 10 errors in 36.00s ===============================================================================================
==> ERROR: A failure occurred in check().
    Aborting...

@dgw
Copy link
Member Author

dgw commented Jul 27, 2022

Hm, the errors in that log look like what happened the last time I tried to run tests in pytest 7, without upgrading xmltodict. I don't think that breakage is related to this specific upgrade.

@dgw dgw closed this Jul 29, 2022
@dgw dgw reopened this Jul 29, 2022
@dgw
Copy link
Member Author

dgw commented Jul 29, 2022

Damn it, I did the misclick thing again. Anyway, I vote to delay this (my own PR, yes) until after #2328.

No, I don't know why the tests that were passing now fail flake8. I didn't touch those, but something must have updated upstream.

@dgw
reqs: allow xmltodict 0.13
d079387 
I tried and tried, but couldn't find any reason not to allow the newer
version of xmltodict now that we no longer support Python 2.
@dgw
Copy link
Member Author

dgw commented Aug 13, 2022

OK, same change but on top of pyproject.toml after merging #2328.

Exirel
Exirel requested changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested. Once fixed you can directly go to merge in my opinion, as tests pass.

pyproject.toml Outdated Show resolved Hide resolved
@dgw dgw requested a review from Exirel August 15, 2022 21:15
@dgw dgw merged commit 3af2cbc into master Aug 17, 2022
@dgw dgw deleted the xmltodict-0.13 branch August 17, 2022 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Exirel Exirel Exirel approved these changes

Assignees
No one assigned
Labels
Build
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dgw @Strykar @Exirel