Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

currency: fiat_provider config option takes precedence #2330

Merged
merged 1 commit into from
Aug 12, 2022
Merged

currency: fiat_provider config option takes precedence #2330

merged 1 commit into from
Aug 12, 2022

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jul 23, 2022

Description

Tin, part of #2120.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Jul 23, 2022
@Exirel Exirel added this to the 8.0.0 milestone Jul 23, 2022
@Exirel Exirel mentioned this pull request Jul 23, 2022
Closed
3 tasks
dgw
dgw approved these changes Jul 24, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm nitpicking. There's nothing actually "wrong" with the patch; it just took a bit more mental energy to review than it would have otherwise due to extraneous code style changes. :P

sopel/modules/currency.py Outdated Show resolved Hide resolved
@Exirel
Copy link
Contributor Author

Exirel commented Aug 5, 2022

And done.

@Exirel Exirel requested a review from dgw August 5, 2022 23:04
dgw
dgw approved these changes Aug 7, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick resolved, I see. Squash away 🚀

@Exirel Exirel force-pushed the currency-fiat-provider-precedence branch from cb9bac0 to e9e090d Compare August 11, 2022 22:37
@dgw dgw merged commit e45d69b into sopel-irc:master Aug 12, 2022
@Exirel Exirel deleted the currency-fiat-provider-precedence branch April 8, 2023 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide Housekeeping Code cleanup, removal of deprecated stuff, etc.
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw