irc: use deque for "stack" of recent messages #2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for breaking CI, Coveralls. Thankfully it doesn't actually matter yet, because this is only a draft. |
|
Neat. |
|
Coveralls is fixed. Still keeping as draft until the base PR is completed. |
4 tasks
|
Further discussion on #2320 says we should keep thinking about this, perhaps converting the "stack" to prune messages not just by a dumb count, but by time range and/or maximum size in bytes. This can be considered Replaced if one of us gets the motivation to do the fancy way pre-8.0, but should be merged if we don't. |
Doesn't save any code lines, but does make the process of updating what has been said recently look a bit less voodoo-y. I very much prefer declaring how long the list of "messages" should be where it's initialized instead of pruning it later.
dgw
force-pushed
the
message-stack-deque
branch
from
98660eb to
16f8ca3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tin. Reading #2320 made me wonder why we used a list with manual pruning (
l = l[-10:]after appending), and I couldn't think of a good reason. Updated tests made me pretty confident I could just swap to a deque withmaxlenand get pruning for free.Checklist
make qa(runsmake qualityandmake test)masterbranch (they reference code that wasn't changed in this patch).Notes
This is a draft because it's built on top of #2320. I will rebase and mark ready for review when that's squashed down.