url: remove traceback from debug log when fetching URL fails #2280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If url.py can't connect to a server because of things like certificate issues (https://expired.badssl.com/), DNS (http://fake.host.local/), etc, it currently dumps most of a page of exception tracebacks into logs. This is useful to nobody, and it shouldn't do that.
This patch replaces the page of tracebacks with the following:
sopel.modules.url DEBUG - Unable to reach URL: 'http://fake.host/': HTTPConnectionPool(host='fake.host', port=80): Max retries exceeded with url: / (Caused by NewConnectionError('<urllib3.connection.HTTPConnection object at 0x7f95ef238340>: Failed to establish a new connection: [Errno -2] Name or service not known'))
I think that's quite sufficient for troubleshooting without being excessively spammy.
Checklist
make qa
(runsmake quality
andmake test
)