Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

config: deprecate using a comma instead of a newline in ListAttribute #2252

Merged
merged 1 commit into from
Feb 24, 2022
Merged

config: deprecate using a comma instead of a newline in ListAttribute #2252

merged 1 commit into from
Feb 24, 2022

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Feb 10, 2022

Description

Tin, according to the step for 8.x of #1626.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added Low Priority Housekeeping Code cleanup, removal of deprecated stuff, etc. labels Feb 10, 2022
@Exirel Exirel added this to the 8.0.0 milestone Feb 10, 2022
@Exirel Exirel mentioned this pull request Feb 10, 2022
Open
6 tasks
dgw
dgw reviewed Feb 10, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About those tweaked docs: It turns out that I'm a nitpicker. Who knew?

sopel/config/types.py Outdated Show resolved Hide resolved
sopel/config/types.py Show resolved Hide resolved
sopel/config/types.py Show resolved Hide resolved
sopel/config/types.py Outdated Show resolved Hide resolved
sopel/config/types.py Outdated Show resolved Hide resolved
@Exirel Exirel requested a review from dgw February 23, 2022 09:30
@Exirel
Copy link
Contributor Author

Exirel commented Feb 23, 2022

Apparently I forgot to ask a re-review.

dgw
dgw reviewed Feb 24, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one last nitpick. Feel free to squash-and-apply in one step.

sopel/config/types.py Outdated Show resolved Hide resolved
dgw
dgw approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, any typos/etc. that eluded me this long deserve to make it into master.

@Exirel @dgw
config: emit a warning log when ListAttribute is used with comma deli…
d3ac714 
…miter syntax instead of new-lines

Co-authored-by: dgw <dgw@technobabbl.es>
@Exirel Exirel force-pushed the config-listattr-deprecate-comma branch from d40ca0e to d3ac714 Compare February 24, 2022 15:29
@Exirel
Copy link
Contributor Author

Exirel commented Feb 24, 2022

squash-and-apply

It has been done.

@dgw dgw merged commit b1e8753 into sopel-irc:master Feb 24, 2022
@Exirel Exirel deleted the config-listattr-deprecate-comma branch February 24, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Housekeeping Code cleanup, removal of deprecated stuff, etc. Low Priority
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw