Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate: update langcode() helper to support Chinese #2242

Merged
merged 1 commit into from
Feb 6, 2022

Conversation

dgw
Copy link
Member

@dgw dgw commented Jan 23, 2022

Description

This is a semi-temporary fix for #2241. It's still not perfect (still allows using unsupported or nonexistent language codes), but there will be additional options available in Sopel 8.0 and beyond. Goal for this is to avoid adding any new dependencies in 7.1.x.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

This is a semi-temporary fix for #2241. It's still not perfect (still
allows using unsupported or nonexistent language codes), but there will
be additional options available in Sopel 8.0 and beyond. Goal for this
is to avoid adding any new dependencies in 7.1.x.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Jan 23, 2022
@dgw dgw added this to the 7.1.8 milestone Jan 23, 2022
@dgw dgw requested a review from a team January 23, 2022 10:59
@dgw dgw force-pushed the translate-zh-flags branch from c84ebfb to 037bb32 Compare January 23, 2022 11:00
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a nitpick, doesn't prevent approval.

sopel/modules/translate.py Show resolved Hide resolved
@dgw dgw merged commit c812145 into master Feb 6, 2022
@dgw dgw deleted the translate-zh-flags branch February 6, 2022 21:29
dgw added a commit that referenced this pull request Feb 6, 2022
translate: update `langcode()` helper to support Chinese
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants