Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

isup: catch up errors from get site and from requests differently #2235

Merged
merged 2 commits into from
Jan 7, 2022
Merged

isup: catch up errors from get site and from requests differently #2235

merged 2 commits into from
Jan 7, 2022

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented Jan 6, 2022

Description

Annoying little update from requests 2.27 that has a different behavior and doesn't work exactly the same way with requests_mock.

This fix works for both 7.1.x and 8.x.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@Exirel Exirel added Tweak Bugfix Generally, PRs that reference (and fix) one or more issue(s) labels Jan 6, 2022
@Exirel Exirel added this to the 8.0.0 milestone Jan 6, 2022
Exirel added 2 commits January 7, 2022 00:44
@Exirel
isup: catch up errors from get site and from requests differently
d25ec20
@Exirel
requirements: narrow requests to >=2.24
96d37e5 
Sopel's other dependencies require requests>=24 at minimum, so there is
no sense in requiring only 2.0. Also, 2.0 is old, 2.24 is a good minimum
(and it's still compatible with 2.7).
@Exirel Exirel force-pushed the isup-reply-error-message-value-error branch from e768dbd to 96d37e5 Compare January 6, 2022 23:44
@dgw dgw modified the milestones: 8.0.0, 7.1.8 Jan 7, 2022
@dgw
Copy link
Member

dgw commented Jan 7, 2022

Which version(s) of requests did you test against, besides 2.27?

@Exirel
Copy link
Contributor Author

Exirel commented Jan 7, 2022

2.24, 2.26, 2.27.

@dgw dgw enabled auto-merge January 7, 2022 20:13
dgw
dgw approved these changes Jan 7, 2022
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'll keep an eye on the CI build for 7.1.x once backported.

@dgw dgw merged commit 787baa6 into sopel-irc:master Jan 7, 2022
dgw added a commit that referenced this pull request Jan 7, 2022
@dgw
Backport pull request #2235
a4a6c7e 
isup: catch up errors from get site and from requests differently

Requirements changes have been adapted to 7.1.x's stack.
@Exirel Exirel deleted the isup-reply-error-message-value-error branch January 20, 2022 07:34
@dgw
Copy link
Member

dgw commented Feb 20, 2022 •
edited
Loading

@Exirel Backports to 7.1.x all appear fine except for this patch, which according to Travis logs raised the minimum requests version too far for py3.4 to be happy. Do you mind looking into whether requests>=2.21.0 would work OK?

@dgw
Copy link
Member

dgw commented Feb 20, 2022

Fixed by hand-holding pip on py3.4 to select an appropriate version. CI passes.

Yeah, all of us are pretty psyched about finishing up some 8.0 stuff and leaving all these deadsnakes behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s) Tweak
Projects
None yet
Milestone
7.1.8
Development

Successfully merging this pull request may close these issues.
2 participants
@Exirel @dgw