Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia: refine no-consume logic for section hatnotes #2225

Merged
merged 1 commit into from
Dec 26, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Dec 20, 2021

Description

Sometimes note templates include inline style tags. Since their contents appear just like any other data to the parser, it will output the CSS unless told to ignore them.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

Notes

I'm not going to start a 7.1.8 milestone just for this, because it's quite the edge case. But if some other more important bug crops up that is worth starting a milestone for, this should be included.

Sometimes note templates include inline style tags. Since their contents
appear just like any other data to the parser, it will output the CSS
unless told to ignore them.
@dgw dgw added the Bugfix Generally, PRs that reference (and fix) one or more issue(s) label Dec 20, 2021
@dgw dgw added this to the 8.0.0 milestone Dec 20, 2021
@dgw dgw requested a review from a team December 20, 2021 07:12
Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds sane. As sane as a parser can be.

@dgw dgw merged commit c1f32aa into master Dec 26, 2021
@dgw dgw deleted the wikipedia-ignore-hatnotes branch December 26, 2021 17:31
dgw added a commit that referenced this pull request Dec 26, 2021
wikipedia: refine no-consume logic for section hatnotes
@dgw dgw modified the milestones: 8.0.0, 7.1.8 Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bugfix Generally, PRs that reference (and fix) one or more issue(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants