plugins: execute TODO that was waiting for end of py2 support #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yikes, I didn't realize this branch was already linked to a PR and thought I was adding to a WIP. Can either finish/fix the additional changes, or revert and make them in a separate patch. |
I'd rather see it reverted, because it was already approved. The import thing requires more time to check what is going on exactly. |
|
This should be back to the originally approved/passing state. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We can use
collections.OrderedDict.move_to_end()now.Checklist
make qa(runsmake qualityandmake test)Notes
Yes, I know CI is going to fail pending resolution of #2210. Hoping the revert will happen soon and Python 3.9.x will get the "expedited release" that a maintainer requested at the Python bug tracker.