web: use html.unescape() when available (Python 3.4+)
#2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
the
Bugfix
dgw
force-pushed
the
modernize-web.decode
branch
from
602f028 to
a321946
Compare
Exirel
approved these changes
Oct 30, 2021
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2203 on Python 3.4+ hosts. Anything older, well, we're not going to ship a reimplementation of Python's
html.unescape()function (and everything else that actually makes it work) in a patch release when we've already dropped support for those Python versions on master. This bug just isn't a showstopper. It's not worth that.Checklist
make qa(runsmake qualityandmake test)make qualityraises E741 on a variable name insopel/modules/help.py, but that's nothing to do with this patch and it's not going to be an issue on the older version of flake8 configured for use on 7.1.x.