reddit: fix shortlinks #2202
Merged
reddit: fix shortlinks #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
half-duplex
added
the
Bugfix
half-duplex
force-pushed
the
reddit-shortlinks
branch
from
206a0c0 to
3fc16b2
Compare
dgw
approved these changes
Oct 29, 2021
There was a problem hiding this comment.
Buh, it's always something with this plugin. Nice catch from @xnaas and quick fix by @half-duplex.
4 tasks
dgw
added a commit
that referenced
this pull request
Oct 29, 2021
reddit: fix shortlinks Corresponds to merge on master: 1010e45
dgw
added a commit
that referenced
this pull request
Nov 7, 2021
Addresses a regression introduced by #2202, which added `reddit.com` to the `short_post_url` pattern and made it possible for a post or comment URL to match BOTH that and `post_or_comment_url`. Since URLs match individually, and not as part of the line, all we need to make sure a shortlink really is one is to ensure that the link ends after the submission ID and optional trailing slash.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
reddit.py doesn't correctly handle redd.it shortlinks (anymore), and doesn't handle reddit.com shortlinks at all.
This makes the "comment" group optional, and adds the "submission" group name and reddit.com domain to the shortlink regex.
Checklist
make qa(runsmake qualityandmake test)