wikipedia: handle transcluded sections better #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgw
added
the
Bugfix
Exirel
reviewed
Jul 25, 2021
Not going to say this will work in all cases, but it should handle MOST just fine. It's definitely better than the `KeyError` spat out before.
dgw
force-pushed
the
wikipedia-transcluded-sections
branch
from
990a353 to
dbb4469
Compare
Exirel
approved these changes
Jul 25, 2021
dgw
added a commit
that referenced
this pull request
Aug 11, 2021
wikipedia: handle transcluded sections better Cherry-picked from master: 82e090c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Not going to say this will work in all cases, but it should handle MOST just fine. It's definitely better than the
KeyErrorspat out before. Closes #2167.Checklist
make qa(runsmake qualityandmake test)