Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pronouns: add .clearpronouns command #2154

Merged
merged 1 commit into from
Jul 12, 2021
Merged

Conversation

eliocamp
Copy link
Contributor

@eliocamp eliocamp commented Jul 11, 2021

Description

Adds the ability to clear one's pronouns.

Closes #2137

make qa reports a bunch of issues but unrelated to my change. @dgw edit: It's because the checks were run on py2, which is no longer supported.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw dgw changed the title pronouns: adds .clearpronouns command pronouns: add .clearpronouns command Jul 11, 2021
@dgw dgw added this to the 8.0.0 milestone Jul 11, 2021
@dgw
Copy link
Member

dgw commented Jul 11, 2021

make qa reports a bunch of issues but unrelated to my change.

What issues would those be? It shouldn't report anything, and doesn't in CI.

@eliocamp
Copy link
Contributor Author

I get this:

./checkstyle.sh
./sopel.py:2:1: F407 future feature generator_stop is not defined
./pytest_run.py:13:1: F407 future feature generator_stop is not defined
./setup.py:15:13: E999 SyntaxError: invalid syntax
./sopel/trigger.py:2:1: F407 future feature generator_stop is not defined
./sopel/bot.py:8:1: F407 future feature generator_stop is not defined
./sopel/test_tools.py:19:1: F407 future feature generator_stop is not defined
./sopel/web.py:14:1: F407 future feature generator_stop is not defined
./sopel/logger.py:1:1: F407 future feature generator_stop is not defined
./sopel/plugin.py:10:1: F407 future feature generator_stop is not defined
./sopel/loader.py:12:1: F407 future feature generator_stop is not defined
./sopel/coretasks.py:23:1: F407 future feature generator_stop is not defined
./sopel/__init__.py:41:48: E999 SyntaxError: invalid syntax
./sopel/module.py:8:1: F407 future feature generator_stop is not defined
./sopel/formatting.py:8:1: F407 future feature generator_stop is not defined
./sopel/db.py:1:1: F407 future feature generator_stop is not defined
./sopel/tests/factories.py:5:1: F407 future feature generator_stop is not defined
./sopel/tests/pytest_plugin.py:5:1: F407 future feature generator_stop is not defined
./sopel/tests/mocks.py:5:1: F407 future feature generator_stop is not defined
./sopel/tests/__init__.py:5:1: F407 future feature generator_stop is not defined
./sopel/config/core_section.py:1:1: F407 future feature generator_stop is not defined
./sopel/config/types.py:26:1: F407 future feature generator_stop is not defined
./sopel/config/__init__.py:50:1: F407 future feature generator_stop is not defined
./sopel/irc/utils.py:4:1: F407 future feature generator_stop is not defined
./sopel/irc/abstract_backends.py:4:1: F407 future feature generator_stop is not defined
./sopel/irc/isupport.py:14:1: F407 future feature generator_stop is not defined
./sopel/irc/__init__.py:25:1: F407 future feature generator_stop is not defined
./sopel/irc/backends.py:6:1: F407 future feature generator_stop is not defined
./sopel/modules/py.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/find_updates.py:11:1: F407 future feature generator_stop is not defined
./sopel/modules/choose.py:11:1: F407 future feature generator_stop is not defined
./sopel/modules/adminchannel.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/rand.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/tld.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/bugzilla.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/units.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/search.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/currency.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/invite.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/unicode_info.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/version.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/find.py:14:1: F407 future feature generator_stop is not defined
./sopel/modules/reddit.py:10:1: F407 future feature generator_stop is not defined
./sopel/modules/admin.py:12:1: F407 future feature generator_stop is not defined
./sopel/modules/wiktionary.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/url.py:11:1: F407 future feature generator_stop is not defined
./sopel/modules/translate.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/ip.py:10:1: F407 future feature generator_stop is not defined
./sopel/modules/wikipedia.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/dice.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/meetbot.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/seen.py:10:1: F407 future feature generator_stop is not defined
./sopel/modules/safety.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/help.py:12:1: F407 future feature generator_stop is not defined
./sopel/modules/pronouns.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/isup.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/lmgtfy.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/__init__.py:1:1: F407 future feature generator_stop is not defined
./sopel/modules/countdown.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/reload.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/announce.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/ping.py:7:1: F407 future feature generator_stop is not defined
./sopel/modules/uptime.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/calc.py:8:1: F407 future feature generator_stop is not defined
./sopel/modules/remind.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/xkcd.py:10:1: F407 future feature generator_stop is not defined
./sopel/modules/clock.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/tell.py:9:1: F407 future feature generator_stop is not defined
./sopel/modules/emoticons.py:8:1: F407 future feature generator_stop is not defined
./sopel/cli/utils.py:1:1: F407 future feature generator_stop is not defined
./sopel/cli/plugins.py:2:1: F407 future feature generator_stop is not defined
./sopel/cli/config.py:2:1: F407 future feature generator_stop is not defined
./sopel/cli/__init__.py:1:1: F407 future feature generator_stop is not defined
./sopel/cli/run.py:36:13: E999 SyntaxError: invalid syntax
./sopel/plugins/jobs.py:17:1: F407 future feature generator_stop is not defined
./sopel/plugins/exceptions.py:5:1: F407 future feature generator_stop is not defined
./sopel/plugins/handlers.py:44:1: F407 future feature generator_stop is not defined
./sopel/plugins/rules.py:1678:22: E999 SyntaxError: invalid syntax
./sopel/plugins/__init__.py:29:1: F407 future feature generator_stop is not defined
./sopel/tools/jobs.py:14:1: F407 future feature generator_stop is not defined
./sopel/tools/_events.py:1:1: F407 future feature generator_stop is not defined
./sopel/tools/calculation.py:2:1: F407 future feature generator_stop is not defined
./sopel/tools/web.py:19:1: F407 future feature generator_stop is not defined
./sopel/tools/target.py:1:1: F407 future feature generator_stop is not defined
./sopel/tools/time.py:2:1: F407 future feature generator_stop is not defined
./sopel/tools/__init__.py:627:23: E999 SyntaxError: invalid syntax
./test/test_config.py:1:1: F407 future feature generator_stop is not defined
./test/test_trigger.py:2:1: F407 future feature generator_stop is not defined
./test/test_irc.py:2:1: F407 future feature generator_stop is not defined
./test/test_tools.py:2:1: F407 future feature generator_stop is not defined
./test/test_bot.py:2:1: F407 future feature generator_stop is not defined
./test/test_db.py:6:1: F407 future feature generator_stop is not defined
./test/test_plugins.py:2:1: F407 future feature generator_stop is not defined
./test/test_coretasks.py:2:1: F407 future feature generator_stop is not defined
./test/test_plugin.py:2:1: F407 future feature generator_stop is not defined
./test/test_formatting.py:2:1: F407 future feature generator_stop is not defined
./test/test_module.py:9:1: F407 future feature generator_stop is not defined
./test/test_loader.py:2:1: F407 future feature generator_stop is not defined
./test/tests/test_tests_mocks.py:2:1: F407 future feature generator_stop is not defined
./test/config/test_config_types.py:1:1: F407 future feature generator_stop is not defined
./test/irc/test_irc_abstract_backends.py:2:1: F407 future feature generator_stop is not defined
./test/irc/test_irc_isupport.py:2:1: F407 future feature generator_stop is not defined
./test/irc/test_irc_utils.py:2:1: F407 future feature generator_stop is not defined
./test/modules/test_modules_url.py:2:1: F407 future feature generator_stop is not defined
./test/modules/test_modules_isup.py:2:1: F407 future feature generator_stop is not defined
./test/modules/test_modules_choose.py:2:1: F407 future feature generator_stop is not defined
./test/modules/test_modules_find_updates.py:2:1: F407 future feature generator_stop is not defined
./test/modules/test_modules_tell.py:2:1: F407 future feature generator_stop is not defined
./test/modules/test_modules_remind.py:2:1: F407 future feature generator_stop is not defined
./test/cli/test_cli_utils.py:2:1: F407 future feature generator_stop is not defined
./test/cli/test_cli_run.py:2:1: F407 future feature generator_stop is not defined
./test/plugins/test_plugins_handlers.py:2:1: F407 future feature generator_stop is not defined
./test/plugins/test_plugins_rules.py:2:1: F407 future feature generator_stop is not defined
./test/tools/test_tools_time.py:2:1: F407 future feature generator_stop is not defined
./test/tools/test_tools_target.py:2:1: F407 future feature generator_stop is not defined
./test/tools/test_tools_web.py:2:1: F407 future feature generator_stop is not defined
./test/tools/test_tools_jobs.py:2:1: F407 future feature generator_stop is not defined
ERROR: flake8 does not pass.
Makefile:6: recipe for target 'quality' failed
make: *** [quality] Error 1

@half-duplex
Copy link
Member

It appears you're using a version of Python older than what Sopel 8+ (master) requires, which is 3.6+.

@dgw
Copy link
Member

dgw commented Jul 11, 2021

OK, all of that (especially ./setup.py:15:13: E999 SyntaxError: invalid syntax, pointing to the use of a file kwarg to print()) points to your environment running the checks under Python 2. Sopel 7.1.x will be the last series to support anything below Python 3.6, and much of the master branch has already been updated to drop py2.

@eliocamp
Copy link
Contributor Author

Yes, that's it. Changing the default python to python3 now gives me a different error. Horray!

./checkstyle.sh
coverage run -m py.test -v .
make: coverage: Command not found
Makefile:10: recipe for target 'test' failed
make: *** [test] Error 127

@dgw
Copy link
Member

dgw commented Jul 11, 2021

So you need to pip install -r dev-requirements.txt -r requirements.txt using the correct pip command for that version of Python. Maybe pip3, maybe pip3.6 etc.

@dgw dgw force-pushed the clearpronouns branch from acfcc8b to 3b2fb79 Compare July 11, 2021 23:44
@dgw dgw force-pushed the clearpronouns branch from 3b2fb79 to 8a4eed1 Compare July 11, 2021 23:45
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well and good once LGTM re-approves. Took care of the commit message style myself, same as I would have in #2140 if it hadn't been replaced.

@dgw dgw merged commit f29c10d into sopel-irc:master Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add .clearpronouns command
3 participants