Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia: log a warning if lang_per_channel is used for a channel #2143

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

dgw
Copy link
Member

@dgw dgw commented Jul 3, 2021

Description

If a channel's language setting is loaded from the deprecated wikipedia.lang_per_channel config value, Sopel will log a warning:

[2021-07-03 01:37:59,890] sopel.modules.wikipedia WARNING  - Language for #dgw loaded from the deprecated
config setting, wikipedia.lang_per_channel

Targeted to 7.1.x branch for v7.1.2. Should have been done in #1916.

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
    • flake8 doesn't pass because I have the newer version we use on master, but should pass in 7.1.x CI
  • I have tested the functionality of the things this change touches

@dgw dgw added this to the 7.1.2 milestone Jul 3, 2021
@dgw dgw requested a review from a team July 3, 2021 06:43
@dgw dgw enabled auto-merge July 3, 2021 06:46
@dgw dgw merged commit 1c544f5 into 7.1.x Jul 5, 2021
@dgw dgw deleted the wikipedia-warn-old-lang branch July 5, 2021 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants