coretasks, test: support CHGHOST command/capability #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
Exirel
approved these changes
Jun 24, 2021
4 tasks
dgw
added a commit
to dgw/ircv3.github.io
that referenced
this pull request
Jul 1, 2021
Reduces churn in `bot.users` and `bot.channels` on networks that support the `chghost` CAP, since they send a flood of QUIT, JOIN, and MODE lines to connected clients without `chghost` support in order to emulate the CHGHOST behavior. Also fixes a likely typo in a nearby coretasks test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduces churn in
bot.usersandbot.channelson networks that support thechghostCAP, since they send a flood of QUIT, JOIN, and MODE lines to connected clients withoutchghostsupport in order to emulate the CHGHOST behavior.Checks another box in #971. Also fixes a likely typo in a nearby coretasks test.
Checklist
make qa(runsmake qualityandmake test)Notes
chghostspec for reviewers' reference.