Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wikipedia: modify command names #1966

Merged
merged 1 commit into from Jun 30, 2021
Merged

wikipedia: modify command names #1966

merged 1 commit into from Jun 30, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 20, 2020

No description provided.

Copy link
Contributor

@Exirel Exirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 agree.

@dgw
Copy link
Member

dgw commented Nov 2, 2020

Since this is targeted for a major version bump… what if we were really naughty and just nuked all of the existing command names in favor of .wikipedia and .wp? Honestly, .wiki is a bit too generic—not as bad as .w, but still. 😜

I do have real reasoning behind this idea: Suppose someone wants to make a bot for some media franchise with a ton of very specific info available on a dedicated wiki (official or otherwise). Having .wiki available for use by plugins would let any fandom very easily make a bot that searches the de facto wiki for their niche, with an obvious command name that fits naturally.

@ghost
Copy link
Author

ghost commented Nov 2, 2020

I know this came up in IRC, but I'll comment it here as well.

I think the general consensus is that wp sounds like wordpress and wiki is pretty much automatically assumed as wikipedia, but ¯\_(ツ)_/¯ Obviously go with whatever you think is best. It's your bot, not mine. 😏

@dgw dgw linked an issue Jun 6, 2021 that may be closed by this pull request
@dgw dgw changed the title wikipedia: alias fix (#1912) wikipedia: modify command names Jun 6, 2021
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just formalizing what I said in a comment months ago.

sopel/modules/wikipedia.py Outdated Show resolved Hide resolved
@RustyBower
Copy link
Contributor

I agree. I think we should avoid single character commands as much as possible, there's too much opportunity for collision

Co-authored-by: dgw <dgw@technobabbl.es>
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History cleaned. Didn't expect @xnaas of all people to be one of those Vigilant Mode nerds 😜 so feel free to --amend the commit here with a proper signature.

@Exirel Exirel added the Breaking Change Stuff that probably should be mentioned in a migration guide label Jun 28, 2021
@dgw dgw merged commit 8fcba89 into sopel-irc:master Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Stuff that probably should be mentioned in a migration guide hacktoberfest-accepted Tweak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wikipedia: replace "w" alias with "wp"
3 participants