Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add flake8-import-order #1864

Merged
merged 1 commit into from
May 19, 2020
Merged

Add flake8-import-order #1864

merged 1 commit into from
May 19, 2020

Conversation

half-duplex
Copy link
Member

Description

Adds flake8-import-order and fixes everything it complains about. See #1765

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches [Smoke tested - currently running shout test]

dgw
dgw requested changes May 19, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All right, that wasn't too bad. Out of 108 files, I could check off 88 of them as ready-to-go. Only 20 files have changes I don't really like, and nearly all in one of these categories:

  • Blank lines between third-party imports (why?)
  • Sorting from ... imports after plain imports (solution: use google style as I did in ab9762d)

Also in ab9762d, I configured the application namespace as sopel, which might affect some of this stuff. (I don't think there were any relative imports 1400 commits ago, so my branch doesn't have any changes with . to compare.)

sopel/__init__.py Show resolved Hide resolved
sopel/modules/bugzilla.py Outdated Show resolved Hide resolved
sopel/modules/reddit.py Outdated Show resolved Hide resolved
sopel/modules/search.py Outdated Show resolved Hide resolved
sopel/modules/url.py Outdated Show resolved Hide resolved
test/modules/test_modules_remind.py Outdated Show resolved Hide resolved
test/plugins/test_plugins_handlers.py Outdated Show resolved Hide resolved
test/test_plugins.py Outdated Show resolved Hide resolved
@dgw dgw added this to the 7.1.0 milestone May 19, 2020
@dgw dgw added the Tweak label May 19, 2020
@dgw dgw mentioned this pull request May 19, 2020
Open
9 tasks
@half-duplex half-duplex requested a review from dgw May 19, 2020 00:44
dgw
dgw approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tweak the spaces in setup.cfg and we're good to squash. 👍

setup.cfg Outdated Show resolved Hide resolved
@dgw dgw merged commit 0ae1d8a into sopel-irc:master May 19, 2020
@dgw dgw mentioned this pull request May 19, 2020
Closed
@half-duplex half-duplex deleted the flake8-additions branch May 19, 2020 22:13
@half-duplex half-duplex restored the flake8-additions branch May 14, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

Assignees
No one assigned
Labels
Tweak
Projects
None yet
Milestone
7.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@half-duplex @dgw