-
Notifications
You must be signed in to change notification settings - Fork 650
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches #993
[db_migrator] Support migrating database regarding buffer configuration for all Mellanox switches #993
Conversation
db_migrator supports migrating old configuration who has 2 ingress pools into the new configuration who has 1 ingress pool, including BUFFER_POOL, BUFFER_PROFILE and BUFFER_PORT_INGRESS_PROFILE_LIST Signed-off-by: Stephen Sun <stephens@mellanox.com>
1. Don't need to migrate for single buffer pool mode 2. Move buffer setting migration to another file 3. Remove unnecessary code/upgrading flows Signed-off-by: Stephen Sun <stephens@mellanox.com>
This pull request introduces 2 alerts and fixes 1 when merging e16a8e7 into e3d6ba0 - view on LGTM.com new alerts:
fixed alerts:
|
Signed-off-by: Stephen Sun <stephens@mellanox.com>
This pull request fixes 1 alert when merging 955eac2 into e3d6ba0 - view on LGTM.com fixed alerts:
|
Signed-off-by: Stephen Sun <stephens@mellanox.com>
This pull request fixes 1 alert when merging daf8b8a into e3d6ba0 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging 36ee64e into e3d6ba0 - view on LGTM.com fixed alerts:
|
This issue can fail warm reboot because after warm reboot the buffermgr doesn't have time to generate lossless profiles and the following orchagent bake can fail due to this Signed-off-by: Stephen Sun <stephens@mellanox.com>
This pull request fixes 1 alert when merging 30f7faa into e3d6ba0 - view on LGTM.com fixed alerts:
|
retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please extend your PR message with more information about motivation, which SKUs are affected and how to have this new values enforced.
retest this please |
retest this please |
Done. |
Retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @neethajohn to review the buffer pool values
Retest this please |
Signed-off-by: Stephen Sun <stephens@mellanox.com>
This pull request fixes 1 alert when merging e28c823 into 995cf39 - view on LGTM.com fixed alerts:
|
Signed-off-by: Stephen Sun <stephens@mellanox.com>
This pull request fixes 1 alert when merging 2a7b809 into aa1b072 - view on LGTM.com fixed alerts:
|
This pull request fixes 1 alert when merging e256e93 into 5d26391 - view on LGTM.com fixed alerts:
|
Hi @prsunny , @neethajohn , |
@neethajohn could you please review and see if this can be merged? |
This pull request introduces 1 alert and fixes 1 when merging 488173d into 0225c09 - view on LGTM.com new alerts:
fixed alerts:
|
retest this please |
Signed-off-by: Stephen Sun <stephens@mellanox.com>
Hi @prsunny @neethajohn, |
This pull request fixes 1 alert when merging 66229e5 into 7ae8024 - view on LGTM.com fixed alerts:
|
retest this please |
…on for all Mellanox switches This is to backport PR sonic-net#993 to 201911 Signed-off-by: Stephen Sun <stephens@nvidia.com>
@stephenxs Please create PR for 201911 |
This is the updated version of #990. As the original branch has been forcely updated, we need to open a new PR for it.
All comments in that PR have been addressed in this one.
- What I did
The motivation is not to put too much code in
db_migrator.py
which can distract others from the main logic.The buffer configuration of each database version will be used twice:
CONFIG_DB
.Signed-off-by: Stephen Sun stephens@mellanox.com
- How I did it
- How to verify it
- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)