[acl-loader] Fix bugs in acl-loader #991
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
- What I did/How I did it
I fixed a bug in acl-loader where rules with protocol=0 would have the protocol field ignored due to python's implicit boolean conversion. I fixed this by explicitly adding the
== 0
check to the ip protocol field.I also fixed/added a warning when the provided
--table_name
can't be found in Config DB. Previously this case would fail silently, now the user will receive a warning to point them in the right direction.- How to verify it
Run
acl-loader
with a non-existent--table_name
:Run
acl-loader
with a rule that includes"protocol": 0
:- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)