Explicitly specify command names with underscores (continued) #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
lguohan
reviewed
Mar 24, 2020
|
Retest this please |
|
@lguohan: I addressed your comments last week. Please review again. |
lguohan
reviewed
Apr 2, 2020
lguohan
reviewed
Apr 2, 2020
lguohan
approved these changes
Apr 3, 2020
|
@jleveque Please Create PR 201911. Cherry-pick is not clean |
abdosi
pushed a commit
to abdosi/sonic-utilities
that referenced
this pull request
Aug 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with Click 7.0, the default behavior of a command with underscores will be to replace with dashes.
This is to address the above default behavior change, so that the commands remain the same, extending the work done in #846 to all Click-based SONiC command line utilities.
Resolves #847
More details can be found here: pallets/click#1123
For new subcommands which haven't been included in a release branch yet, use hyphens, as this will be the direction we move in the future. I have also opened an issue to track the eventual transition: #853