Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mellanox] add document for thermal control related cli #832

Merged
merged 3 commits into from
Mar 17, 2020

Conversation

Junchao-Mellanox
Copy link
Collaborator

- What I did

  1. Add command description for show platform fan
  2. Add command description for show platform temperature

- How I did it

- How to verify it

Verify it by preview the markdown document.

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

keboliu
keboliu previously approved these changes Mar 10, 2020
Copy link
Collaborator

@liat-grozovik liat-grozovik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a section of the thermal control with some high level description of the way it should be managed and what are the files should be provided / edited? I think we should have a feature description as well as expected behaviour when feature is enabled/disabled and not just to commands itself.
Can you please add such section?
then i think the show commands which are relevant to that feature should be below the high level feature description

@Junchao-Mellanox
Copy link
Collaborator Author

Junchao-Mellanox commented Mar 11, 2020

Hi @liat-grozovik , I discussed with @keboliu about provide a high level description about thermal policy management. And we agreed to add that section in thermal control design document because the cli document only contains description about command line. You can see it here Junchao-Mellanox/SONiC#2. What's your suggestion?

@liat-grozovik
Copy link
Collaborator

retest this please

1 similar comment
@daall
Copy link
Contributor

daall commented Mar 16, 2020

retest this please

@liat-grozovik liat-grozovik merged commit 45c6c68 into sonic-net:master Mar 17, 2020
@Junchao-Mellanox Junchao-Mellanox deleted the thermal-cli-doc branch May 7, 2020 06:02
abdosi pushed a commit that referenced this pull request Jun 3, 2020
* [Mellanox] add document for thermal control related cli

* Update review comments thermal zones -> thermal sensors

* Make example better
abdosi pushed a commit to abdosi/sonic-utilities that referenced this pull request Aug 4, 2020
* [Mellanox] add document for thermal control related cli

* Update review comments thermal zones -> thermal sensors

* Make example better
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
Make sure db_migrator is run after all config are loaded during (sonic-net#926)
Vnet alias mapping (sonic-net#924)
Changes to make lldp show command for multi-npu platforms. (sonic-net#914)
[Mellanox] Fix thermal control issue: use natural sort for fan
status and thermal status (sonic-net#836)
[Mellanox] add document for thermal control related cli (sonic-net#832)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants