[dropconfig] Move prefix-handling from CLI to orchagent #785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove prefix-trimming from drop reason capability query - Remove prefix-trimming from create/add safety checks Signed-off-by: Danny Allen <daall@microsoft.com>
jleveque
approved these changes
Jan 16, 2020
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
lguohan
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 26, 2020
…asons (#1173) - Refactor drop reason capability query to trim SAI prefixes - Store device capabilities in orchagent to perform safety checks Fixes #1136 - Rather than depending on each ASIC vendor to follow the same error handling doctrine, this PR validates HW support in orchagent, which should be more reliable. Related to sonic-net/sonic-utilities#785 - In order to validate user input, we need to remove the SAI prefixes before we store the results. This removes the need for the CLI to perform these checks. Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 28, 2020
…asons (#1173) - Refactor drop reason capability query to trim SAI prefixes - Store device capabilities in orchagent to perform safety checks Fixes #1136 - Rather than depending on each ASIC vendor to follow the same error handling doctrine, this PR validates HW support in orchagent, which should be more reliable. Related to sonic-net/sonic-utilities#785 - In order to validate user input, we need to remove the SAI prefixes before we store the results. This removes the need for the CLI to perform these checks. Signed-off-by: Danny Allen <daall@microsoft.com>
lguohan
pushed a commit
to sonic-net/sonic-swss
that referenced
this pull request
Jan 30, 2020
…asons (#1173) - Refactor drop reason capability query to trim SAI prefixes - Store device capabilities in orchagent to perform safety checks Fixes #1136 - Rather than depending on each ASIC vendor to follow the same error handling doctrine, this PR validates HW support in orchagent, which should be more reliable. Related to sonic-net/sonic-utilities#785 - In order to validate user input, we need to remove the SAI prefixes before we store the results. This removes the need for the CLI to perform these checks. Signed-off-by: Danny Allen <daall@microsoft.com>
abdosi
pushed a commit
that referenced
this pull request
Feb 4, 2020
- Remove prefix-trimming from drop reason capability query - Remove prefix-trimming from create/add safety checks Signed-off-by: Danny Allen <daall@microsoft.com>
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
1f6982d786292390cf0dc7a3da936e035b7685e4 (HEAD -> 201911, origin/201911) [201911 Flex Counters] Add PFC pause duration counters in microseconds (sonic-net#785) Signed-off-by: Abhishek Dosi <abdosi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Danny Allen daall@microsoft.com
- What I did
I removed some conditions from the drop counter CLI that was handling the presence of "SAI_IN/OUT_DROP_REASON_" in State DB.
- Why I did it
A change was made in SWSS that removed the SAI prefixes from the database, making the prefix removal unnecessary in the CLI.
- How to verify it
The CLI tests have been updated to reflect this change. Additionally, you can load the updated script onto a device running the SWSS changes and verify that the behavior is unchanged.
Depends on: sonic-net/sonic-swss#1173