[neighbor advertiser] raise exception when http endpoint return failure #758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ying Xie <ying.xie@microsoft.com>
ghost
approved these changes
Dec 3, 2019
|
Retest this please |
|
retest this please |
daall
reviewed
Dec 4, 2019
|
retest this please |
yxieca
added a commit
that referenced
this pull request
Dec 11, 2019
…re (#758) * [neighbor advertiser] raise exception when http endpoint return failure Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Delete deprecated error checking code * Add back check for None
abdosi
pushed a commit
that referenced
this pull request
Jan 3, 2020
…re (#758) * [neighbor advertiser] raise exception when http endpoint return failure Signed-off-by: Ying Xie <ying.xie@microsoft.com> * Delete deprecated error checking code * Add back check for None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
raise exception when http endpoint return failure to match the HTTPS handling flow.