Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read config DB for running interface(s) and display per port/interface #594

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Read config DB for running interface(s) and display per port/interface #594

merged 2 commits into from
Aug 15, 2019

Conversation

vasant17
Copy link
Contributor

@vasant17 vasant17 commented Jul 31, 2019 •
edited
Loading

Signed-off-by: Vasant Patil vapatil@linkedin.com

show runningconfiguration interfaces should read configDB instead of /etc/network/interfaces.
Also use the --key option of sonic-cfggen for more granular display.

Testing done:

admin@lnos-x1-a-csw06:~$ show runningconfiguration ?
Usage: show runningconfiguration [OPTIONS] COMMAND [ARGS]...

  Show current running configuration information

Options:
  -?, -h, --help  Show this message and exit.

Commands:
  acl         Show acl running configuration
  all         Show full running configuration
  bgp         Show BGP running configuration
  interfaces  Show interfaces running configuration
  ntp         Show NTP running configuration
  ports       Show ports running configuration
  snmp        Show SNMP information
admin@lnos-x1-a-csw06:~$ show runningconfiguration ports
{
    "Ethernet0": {
        "admin_status": "up", 
        "alias": "Eth1", 
        "index": "1", 
        "lanes": "65,66,67,68", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet4": {
        "admin_status": "up", 
        "alias": "Eth2", 
        "index": "2", 
        "lanes": "69,70,71,72", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet8": {
        "admin_status": "up", 
        "alias": "Eth3", 
        "index": "3", 
        "lanes": "73,74,75,76", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet12": {
        "admin_status": "up", 
        "alias": "Eth4", 
        "index": "4", 
        "lanes": "77,78,79,80", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet16": {
        "admin_status": "up", 
        "alias": "Eth5", 
        "index": "5", 
        "lanes": "33,34,35,36", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet20": {
        "admin_status": "up", 
        "alias": "Eth6", 
        "index": "6", 
        "lanes": "37,38,39,40", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet24": {
        "admin_status": "up", 
        "alias": "Eth7", 
        "index": "7", 
        "lanes": "41,42,43,44", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet28": {
        "admin_status": "up", 
        "alias": "Eth8", 
        "index": "8", 
        "lanes": "45,46,47,48", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet32": {
        "admin_status": "up", 
        "alias": "Eth9", 
        "index": "9", 
        "lanes": "49,50,51,52", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet36": {
        "admin_status": "up", 
        "alias": "Eth10", 
        "index": "10", 
        "lanes": "53,54,55,56", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet40": {
        "admin_status": "up", 
        "alias": "Eth11", 
        "index": "11", 
        "lanes": "57,58,59,60", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet44": {
        "admin_status": "up", 
        "alias": "Eth12", 
        "index": "12", 
        "lanes": "61,62,63,64", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet48": {
        "admin_status": "up", 
        "alias": "Eth13", 
        "index": "13", 
        "lanes": "81,82,83,84", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet52": {
        "admin_status": "up", 
        "alias": "Eth14", 
        "index": "14", 
        "lanes": "85,86,87,88", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet56": {
        "admin_status": "up", 
        "alias": "Eth15", 
        "index": "15", 
        "lanes": "89,90,91,92", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet60": {
        "admin_status": "up", 
        "alias": "Eth16", 
        "index": "16", 
        "lanes": "93,94,95,96", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet64": {
        "admin_status": "up", 
        "alias": "Eth17", 
        "index": "17", 
        "lanes": "97,98,99,100", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet68": {
        "admin_status": "up", 
        "alias": "Eth18", 
        "index": "18", 
        "lanes": "101,102,103,104", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet72": {
        "admin_status": "up", 
        "alias": "Eth19", 
        "index": "19", 
        "lanes": "105,106,107,108", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet76": {
        "admin_status": "up", 
        "alias": "Eth20", 
        "index": "20", 
        "lanes": "109,110,111,112", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet80": {
        "admin_status": "up", 
        "alias": "Eth21", 
        "index": "21", 
        "lanes": "1,2,3,4", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet84": {
        "admin_status": "up", 
        "alias": "Eth22", 
        "index": "22", 
        "lanes": "5,6,7,8", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet88": {
        "admin_status": "up", 
        "alias": "Eth23", 
        "index": "23", 
        "lanes": "9,10,11,12", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet92": {
        "admin_status": "up", 
        "alias": "Eth24", 
        "index": "24", 
        "lanes": "13,14,15,16", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet96": {
        "admin_status": "up", 
        "alias": "Eth25", 
        "index": "25", 
        "lanes": "17,18,19,20", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet100": {
        "admin_status": "up", 
        "alias": "Eth26", 
        "index": "26", 
        "lanes": "21,22,23,24", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet104": {
        "admin_status": "up", 
        "alias": "Eth27", 
        "index": "27", 
        "lanes": "25,26,27,28", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet108": {
        "admin_status": "up", 
        "alias": "Eth28", 
        "index": "28", 
        "lanes": "29,30,31,32", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet112": {
        "admin_status": "up", 
        "alias": "Eth29", 
        "index": "29", 
        "lanes": "113,114,115,116", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet116": {
        "admin_status": "up", 
        "alias": "Eth30", 
        "index": "30", 
        "lanes": "117,118,119,120", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet120": {
        "admin_status": "up", 
        "alias": "Eth31", 
        "index": "31", 
        "lanes": "121,122,123,124", 
        "mtu": "9100", 
        "speed": "100000"
    }, 
    "Ethernet124": {
        "admin_status": "up", 
        "alias": "Eth32", 
        "index": "32", 
        "lanes": "125,126,127,128", 
        "mtu": "9100", 
        "speed": "100000"
    }
}
admin@lnos-x1-a-csw06:~$ show runningconfiguration interfaces 
{
    "Ethernet0|10.0.0.0/31": {
        "family": "IPv4", 
        "scope": "global"
    }, 
    "Ethernet4|10.0.0.2/31": {}, 
    "Ethernet8|10.0.0.4/31": {}, 
    "Ethernet12|10.0.0.6/31": {}, 
    "Ethernet16|10.0.0.8/31": {}, 
    "Ethernet20|10.0.0.10/31": {}, 
    "Ethernet24|10.0.0.12/31": {}, 
    "Ethernet28|10.0.0.14/31": {}, 
    "Ethernet32|10.0.0.16/31": {}, 
    "Ethernet36|10.0.0.18/31": {}, 
    "Ethernet40|10.0.0.20/31": {}, 
    "Ethernet44|10.0.0.22/31": {}, 
    "Ethernet48|10.0.0.24/31": {}, 
    "Ethernet52|10.0.0.26/31": {}, 
    "Ethernet56|10.0.0.28/31": {}, 
    "Ethernet60|10.0.0.30/31": {}, 
    "Ethernet64|10.0.0.32/31": {}, 
    "Ethernet68|10.0.0.34/31": {}, 
    "Ethernet72|10.0.0.36/31": {}, 
    "Ethernet76|10.0.0.38/31": {}, 
    "Ethernet80|10.0.0.40/31": {}, 
    "Ethernet84|10.0.0.42/31": {}, 
    "Ethernet88|10.0.0.44/31": {}, 
    "Ethernet92|10.0.0.46/31": {}, 
    "Ethernet96|10.0.0.48/31": {}, 
    "Ethernet100|10.0.0.50/31": {}, 
    "Ethernet104|10.0.0.52/31": {}, 
    "Ethernet108|10.0.0.54/31": {}, 
    "Ethernet112|10.0.0.56/31": {}, 
    "Ethernet116|10.0.0.58/31": {}, 
    "Ethernet120|10.0.0.60/31": {}, 
    "Ethernet124|10.0.0.62/31": {}
}
admin@lnos-x1-a-csw06:~$ show runningconfiguration ports Ethernet4
{
    "Ethernet4": {
        "index": "2", 
        "lanes": "69,70,71,72", 
        "mtu": "9100", 
        "alias": "Eth2", 
        "admin_status": "up", 
        "speed": "100000"
    }
}
admin@lnos-x1-a-csw06:~$ show runningconfiguration ports Ethernet40
{
    "Ethernet40": {
        "index": "11", 
        "lanes": "57,58,59,60", 
        "mtu": "9100", 
        "alias": "Eth11", 
        "admin_status": "up", 
        "speed": "100000"
    }
}
admin@lnos-x1-a-csw06:~$ show runningconfiguration interfaces Ethernet4
{
    "Ethernet4|10.0.0.2/31": {}
}
admin@lnos-x1-a-csw06:~$ show runningconfiguration interfaces Ethernet40
{
    "Ethernet40|10.0.0.20/31": {}
}
admin@lnos-x1-a-csw06:~$

- What I did

- How I did it

- How to verify it

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

-->

@prsunny
Copy link
Contributor

prsunny commented Aug 6, 2019

I see two output in descrption for the same command. What is the intended behavior?

admin@lnos-x1-a-csw06:~$ show runningconfiguration interfaces
{
    "Ethernet4|10.0.0.2/31": {}, 
    "Ethernet8|10.0.0.4/31": {}, 
    "Ethernet12|10.0.0.6/31": {},

admin@lnos-x1-a-csw06:~$ show runningconfiguration interface
{
    "Ethernet0": {
        "admin_status": "up", 
        "alias": "Eth1", 
        "index": "1", 
        "lanes": "65,66,67,68", 
        "mtu": "9100", 
        "speed": "100000"
    },

@vasant17
Copy link
Contributor Author

vasant17 commented Aug 6, 2019 •
edited
Loading

Hi Sunny,

"show runningconfiguration interface" and "show runningconfiguration interfaces" are two different commands. One ends with "intreface" and other one with "interfaces"

[admin@lnos-x1-a-csw06:~$ show runningconfiguration interface --verbose
Command: sonic-cfggen -d --var-json PORT
...
admin@lnos-x1-a-csw06:~$ show runningconfiguration interfaces --verbose
Command: sonic-cfggen -d --var-json INTERFACE
....
](url)

I think these are NOT intuitive, we should change them.
I think we should correct them as "show runningconfiguration ports" and "show runningconfiguration interfaces" for PORT and INTERFACE respectively.

@prsunny
Copy link
Contributor

prsunny commented Aug 6, 2019

Hi Sunny,
"show runningconfiguration interface" and "show runningconfiguration interfaces" are two different commands. One ends with "intreface" and other one with "interfaces"
admin@lnos-x1-a-csw06:$ show runningconfiguration interface --verbose
Command: sonic-cfggen -d --var-json PORT
...
admin@lnos-x1-a-csw06:$ show runningconfiguration interfaces --verbose
Command: sonic-cfggen -d --var-json INTERFACE
....

I think these are NOT intuitive, we should change them.
I think we should correct them as "show runningconfiguration ports" and "show runningconfiguration interfaces" for PORT and INTERFACE respectively.

@vasant17 , I think it is confusing. Especially since we can give short names in CLI command like 'show running int'. Kindly change to port for the first case

@vasant17
Copy link
Contributor Author

vasant17 commented Aug 6, 2019 •
edited
Loading

Hi Sunny,

I do understand the issue. Infact "show runningconfiguration int" is an invalid command, as long as the last word in CLI has ambiguous branches, it does NOT accept it has valid command. And "show runningconfiguration ?" does display interface and interfaces options and descriptions.

I need to evaluate after effects of changing interface to port. Hence I will take it up as a different PR.

Just for our records. Original PR when this change went in:
#557

jleveque
jleveque suggested changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@jleveque jleveque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I completely agree with @prsunny.

@vasant17: Please rename the show runningconfiguration interface command to show runningconfiguration port. This will prevent a lot of confusion.

@vasant17 vasant17 closed this Aug 7, 2019
@vasant17 vasant17 reopened this Aug 7, 2019
@vasant17
Copy link
Contributor Author

vasant17 commented Aug 8, 2019

I completely agree with @prsunny.

@vasant17: Please rename the show runningconfiguration interface command to show runningconfiguration port. This will prevent a lot of confusion.

Hi Joe,

Thanks for looking into this. I do agree with the issue, but please note that it has NOT been introduced in this PR. Instead we should have caught it while reviewing #557

Nevertheless, I am working on fixing it, but all that I am saying is: I do NOT want to mix these issues. I have created another pull request to rename " interface" to "ports" in "show runningconfiguration ..." CLI command. Please review it #600

Please let me know if you have any other comments on this PR. Once PR #600 is merged, I will rebase this one.

@jleveque
Copy link
Contributor

jleveque commented Aug 8, 2019 •
edited
Loading

@vasant17: I understand that you didn't introduce the naming issue. I take responsibility for missing that when reviewing #557. I appreciate you changing it to prevent future confusion, and I agree it is better to make the change part of a separate PR. :)

Vasant Patil added 2 commits August 13, 2019 14:08
Read config DB for running interface(s) and display per port/interface
c51a307 
Signed-off-by: Vasant Patil <vapatil@linkedin.com>
Addressed code-review comments
ff444fd 
Signed-off-by: Vasant Patil <vapatil@linkedin.com>
@vasant17 vasant17 force-pushed the show_runningconfig_per_interface branch 2 times, most recently from 6801746 to ff444fd Compare August 13, 2019 22:12
@vasant17
Copy link
Contributor Author

Retest this please

@jleveque jleveque merged commit 9401efd into sonic-net:master Aug 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@jleveque jleveque jleveque approved these changes

@zhenggen-xu zhenggen-xu zhenggen-xu approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vasant17 @prsunny @jleveque @lguohan @zhenggen-xu