Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[show] show interface status added vlan and portchannels to command #483

Merged
merged 5 commits into from
Mar 21, 2019
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
220 changes: 205 additions & 15 deletions scripts/intfutil
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
#! /usr/bin/python
#! /usr/bin/python
tsvanduyn marked this conversation as resolved.
Show resolved Hide resolved

import swsssdk
import sys
import re
import types
from tabulate import tabulate
from natsort import natsorted

from swsssdk import ConfigDBConnector
from pprint import pprint


# ========================== Common interface-utils logic ==========================
Expand All @@ -23,42 +25,75 @@ PORT_DESCRIPTION = "description"
PORT_OPTICS_TYPE = "type"
PORT_PFC_ASYM_STATUS = "pfc_asym"

def db_connect_configdb():
"""
Connect to configdb
"""
config_db = ConfigDBConnector()
if config_db is None:
return None
config_db.connect()
return config_db


def get_interface_vlan_dict(config_db):
"""
Get info from REDIS ConfigDB and create interface to vlan mapping
"""
get_int_vlan_configdb_info = config_db.get_table('VLAN_MEMBER')
int_list = []
vlan_list = []
for line in get_int_vlan_configdb_info:
vlan_number = line[0]
interface = line[1]
int_list.append(interface)
vlan_list.append(vlan_number)
int_to_vlan_dict = dict(zip(int_list, vlan_list))
return int_to_vlan_dict


def config_db_vlan_port_keys_get(int_to_vlan_dict, intf_name):
"""
Get interface vlan value and return it.
"""
vlan = "routed"
if intf_name.startswith("Ethernet"):
tsvanduyn marked this conversation as resolved.
Show resolved Hide resolved
if intf_name in int_to_vlan_dict.keys():
vlan = int_to_vlan_dict[intf_name]
return vlan


def db_connect_appl():
appl_db = swsssdk.SonicV2Connector(host='127.0.0.1')
if appl_db is None:
return None

appl_db.connect(appl_db.APPL_DB)

return appl_db


def appl_db_keys_get(appl_db, intf_name):

"""
Get APPL_DB Keys
"""
if intf_name is None:
appl_db_keys = appl_db.keys(appl_db.APPL_DB, "PORT_TABLE:*")
elif intf_name.startswith('Ethernet'):
tsvanduyn marked this conversation as resolved.
Show resolved Hide resolved
appl_db_keys = appl_db.keys(appl_db.APPL_DB, "PORT_TABLE:%s" % intf_name)
appl_db_keys = db.keys(appl_db.APPL_DB, "PORT_TABLE:%s" % intf_name)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

break #427 again

else:
return None

return appl_db_keys


def appl_db_port_status_get(appl_db, intf_name, status_type):
"""
Get the port status
"""

full_table_id = PORT_STATUS_TABLE_PREFIX + intf_name
status = appl_db.get(appl_db.APPL_DB, full_table_id, status_type)
if status is None:
return "N/A"

if status_type == PORT_SPEED and status != "N/A":
status = '{}G'.format(status[:-3])

return status


Expand All @@ -83,13 +118,136 @@ def state_db_port_optics_get(state_db, intf_name, type):
return "N/A"
return optics_type

def merge(x,y):
# store a copy of x, but overwrite with y's values where applicable
merged = dict(x,**y)
xkeys = x.keys()
# if the value of merged[key] was overwritten with y[key]'s value
# then we need to put back any missing x[key] values
for key in xkeys:
# if this key is a dictionary, recurse
if type(x[key]) is types.DictType and y.has_key(key):
merged[key] = merge(x[key],y[key])
return merged

def convert(tup, new_dict):
tsvanduyn marked this conversation as resolved.
Show resolved Hide resolved
"""
From a tuple create a dictionary that uses the first item in the tuple as a key
and the 2nd item in the tuple as a value.
"""
for a, b in tup:
new_dict.setdefault(a, []).append(b)
return new_dict


def get_raw_portchannel_info(config_db):
"""
This function uses the redis config_db as input and get getting the "PORTCHANNEL_MEMBER" tables
tsvanduyn marked this conversation as resolved.
Show resolved Hide resolved
create
>>> get_po_int_configdb_info = get_portchannel_info(config_db)
>>> pprint(get_po_int_configdb_info)
{('PortChannel0001', 'Ethernet108'): {},
('PortChannel0001', 'Ethernet112'): {},
('PortChannel0002', 'Ethernet116'): {},
('PortChannel0003', 'Ethernet120'): {},
('PortChannel0004', 'Ethernet124'): {}}
This function returns a dictionary with the key being portchannels and interface tuple.
"""
get_raw_po_int_configdb_info = config_db.get_table('PORTCHANNEL_MEMBER')
return get_raw_po_int_configdb_info # Return a dictionary with the key being the portchannel and interface

def get_portchannel_list(get_raw_po_int_configdb_info):
"""
>>> portchannel_list = get_portchannel_list(get_raw_po_int_configdb_info)
>>> pprint(portchannel_list)
['PortChannel0001', 'PortChannel0002', 'PortChannel0003', 'PortChannel0004']
>>>
"""
portchannel_list = []
for po in get_raw_po_int_configdb_info:
portchannel = po[0]
if portchannel not in portchannel_list:
portchannel_list.append(portchannel)
portchannel = portchannel_list.sort()
return portchannel_list

def create_po_int_tuple_list(get_raw_po_int_configdb_info):
"""

tsvanduyn marked this conversation as resolved.
Show resolved Hide resolved
>>> po_int_tuple = get_raw_po_int_configdb_info.keys()
>>> pprint(po_int_tuple_list)
[('PortChannel0001', 'Ethernet108'),
('PortChannel0002', 'Ethernet116'),
('PortChannel0004', 'Ethernet124'),
('PortChannel0003', 'Ethernet120'),
('PortChannel0001', 'Ethernet112')]
>>>
"""
po_int_tuple_list = get_raw_po_int_configdb_info.keys()
return po_int_tuple_list

def create_po_int_dict(po_int_tuple_list):
temp_dict = {}
po_int_dict = convert(po_int_tuple_list, temp_dict)
return po_int_dict

def create_int_to_portchannel_dict(po_int_tuple_list):
int_po_dict = {}
for po, intf in po_int_tuple_list:
int_po_dict.setdefault(intf, po)
return int_po_dict

def po_speed_dict(po_int_dict, appl_db):
if po_int_dict:
po_list = []
for key, value in po_int_dict.iteritems():
agg_speed_list = []
po_list.append(key)
if len(value) == 1:
interface_speed = appl_db.get(appl_db.APPL_DB, "PORT_TABLE:" + value[0], "speed")
interface_speed = '{}G'.format(interface_speed[:-3])
po_list.append(interface_speed)
elif len(value) > 1:
for intf in value:
temp_speed = appl_db.get(appl_db.APPL_DB, "PORT_TABLE:" + intf, "speed")
temp_speed = int(temp_speed)
agg_speed_list.append(temp_speed)
interface_speed = sum(agg_speed_list)
interface_speed = str(interface_speed)
interface_speed = '{}G'.format(interface_speed[:-3])
po_list.append(interface_speed)
po_speed_dict = dict(po_list[i:i+2] for i in range(0, len(po_list), 2))
return po_speed_dict
else:
po_speed_dict = {}
return po_speed_dict

def appl_db_portchannel_status_get(appl_db, po_name, status_type, portchannel_speed_dict):
"""
Get the port status
"""
full_table_id = "LAG_TABLE:" + po_name
#print(full_table_id)
if status_type == "speed":
status = portchannel_speed_dict[po_name]
return status
if status_type == "vlan":
status = "routed"
return status
status = appl_db.get(appl_db.APPL_DB, full_table_id, status_type)
#print(status)
if status is None:
return "N/A"
return status


# ========================== interface-status logic ==========================

header_stat = ['Interface', 'Lanes', 'Speed', 'MTU', 'Alias', 'Oper', 'Admin', 'Type', 'Asym PFC']
header_stat = ['Interface', 'Lanes', 'Speed', 'MTU', 'Alias', 'Vlan', 'Oper', 'Admin', 'Type', 'Asym PFC']

class IntfStatus(object):

def display_intf_status(self, appl_db_keys):
def display_intf_status(self, appl_db_keys, portchannel_speed_dict):
"""
Generate interface-status output
"""
Expand All @@ -110,28 +268,58 @@ class IntfStatus(object):
appl_db_port_status_get(self.appl_db, key, PORT_SPEED),
appl_db_port_status_get(self.appl_db, key, PORT_MTU_STATUS),
appl_db_port_status_get(self.appl_db, key, PORT_ALIAS),
config_db_vlan_port_keys_get(self.combined_int_to_vlan_po_dict, key),
appl_db_port_status_get(self.appl_db, key, PORT_OPER_STATUS),
appl_db_port_status_get(self.appl_db, key, PORT_ADMIN_STATUS),
state_db_port_optics_get(self.state_db, key, PORT_OPTICS_TYPE),
appl_db_port_status_get(self.appl_db, key, PORT_PFC_ASYM_STATUS)))

# Sorting and tabulating the result table.
for po, value in portchannel_speed_dict.iteritems():
if po:
table.append((po,
appl_db_portchannel_status_get(self.appl_db, po, PORT_LANES_STATUS, self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, PORT_SPEED, self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, PORT_MTU_STATUS, self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, PORT_ALIAS, self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, "vlan", self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, PORT_OPER_STATUS, self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, PORT_ADMIN_STATUS, self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, PORT_OPTICS_TYPE, self.portchannel_speed_dict),
appl_db_portchannel_status_get(self.appl_db, po, PORT_PFC_ASYM_STATUS, self.portchannel_speed_dict)))

sorted_table = natsorted(table)
print tabulate(sorted_table, header_stat, tablefmt="simple", stralign='right')


def __init__(self, intf_name):

"""
Class constructor method
:param self:
:param intf_name: string of interface
:return:
"""
self.appl_db = db_connect_appl()
self.state_db = db_connect_state()
self.config_db = db_connect_configdb()
if self.appl_db is None:
return
if self.state_db is None:
return
if self.config_db is None:
return
appl_db_keys = appl_db_keys_get(self.appl_db, intf_name)
self.int_to_vlan_dict = get_interface_vlan_dict(self.config_db)
self.get_raw_po_int_configdb_info = get_raw_portchannel_info(self.config_db)
self.portchannel_list = get_portchannel_list(self.get_raw_po_int_configdb_info)
self.po_int_tuple_list = create_po_int_tuple_list(self.get_raw_po_int_configdb_info)
self.po_int_dict = create_po_int_dict(self.po_int_tuple_list)
self.int_po_dict = create_int_to_portchannel_dict(self.po_int_tuple_list)
self.combined_int_to_vlan_po_dict = merge(self.int_to_vlan_dict, self.int_po_dict)
self.portchannel_speed_dict = po_speed_dict(self.po_int_dict, self.appl_db)
self.portchannel_keys = self.portchannel_speed_dict.keys()
if appl_db_keys is None:
return
self.display_intf_status(appl_db_keys)
self.display_intf_status(appl_db_keys, self.portchannel_speed_dict)



Expand Down Expand Up @@ -204,3 +392,5 @@ def main(args):

if __name__ == "__main__":
main(sys.argv[1:])

tsvanduyn marked this conversation as resolved.
Show resolved Hide resolved