[Mellanox] Update the save_file command in generate_dump to handle folders #3631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when a folder was given to be saved using this function, an empty file with the folder name would be created.
liat-grozovik
changed the title
liat-grozovik
approved these changes
Nov 27, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-utilities
that referenced
this pull request
Nov 30, 2024
…lders (sonic-net#3631) - What I did Support saving folders. - How I did it Add a check to the save_file command, if the path that was provided is to a folder, use an appropriate method. - How to verify it Previously when a folder was given to be saved using this function, an empty file with the folder name would be created.
|
Cherry-pick PR to 202405: #3639 |
mssonicbld
pushed a commit
that referenced
this pull request
Nov 30, 2024
…lders (#3631) - What I did Support saving folders. - How I did it Add a check to the save_file command, if the path that was provided is to a folder, use an appropriate method. - How to verify it Previously when a folder was given to be saved using this function, an empty file with the folder name would be created.
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Support saving folders.
How I did it
Add a check to the save_file command, if the path that was provided is to a folder, use an appropriate method.
How to verify it
Previously when a folder was given to be saved using this function, an empty file with the folder name would be created.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)