Revert "Remove suppress-fib-pending CLI and make route_check.py check suppress-fib in BGP configuration" #3477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… suppres…" This reverts commit 06965df.
|
@stepanblyschak plaese review |
|
Hi @StormLiangMS , Is there any plan to revert #3391 in 202405? Have created sonic-net/sonic-mgmt#14381 |
|
viz @kevinwangsk , need this in 202405 |
|
We should not be taking this change in 202405 as we don't have the required memory enhancements that are part of master only. From 202411 we will have fib suppression feature. |
|
Hi @dgsudharsan , should we skip sonic mgmt test for this in 202405 in that case? |
This was referenced Sep 18, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3331
BGP zebra enhancements is merged to master branch sonic-net/sonic-buildimage#19717
Reverting the revert of bgp suppress pending feature to enable it in master branch