Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fabric monitoring commands. #3239

Merged

Conversation

jfeng-arista
Copy link
Contributor

@jfeng-arista jfeng-arista commented Mar 23, 2024

What I did

Add a force option for config fabric port unisolate command.

Add a show command to display if a up link is get isolated or not . Example output is :

# show fabric isolation
asic0
  Local Link    Auto Isolated    Manual Isolated    Isolated
------------  ---------------  -----------------  ----------
           0                0                  0           0
           1                0                  0           0
           2                0                  0           0
....

Add test for the new commands.
The test is failed now as it needs this sonic-net/sonic-swss#3089 merged in first.

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

@jfeng-arista
Copy link
Contributor Author

the test failure needs this sonic-net/sonic-swss#3089 merged in first.
I could comment out failure test case for now, but that will cause the coverage check fail, let me know if we should leave this as is for now. thank you

@jfeng-arista
Copy link
Contributor Author

@vmittal-msft @arlakshm

Copy link
Contributor

@arlakshm arlakshm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as comments

config/fabric.py Outdated Show resolved Hide resolved
config/fabric.py Outdated Show resolved Hide resolved
@arlakshm
Copy link
Contributor

/Azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arlakshm arlakshm merged commit b143ea6 into sonic-net:master Apr 22, 2024
5 checks passed
arfeigin pushed a commit to arfeigin/sonic-utilities that referenced this pull request Jun 16, 2024
What I did
Add a force option for config fabric port unisolate command.

Add a show command to display if a up link is get isolated or not . Example output is :

# show fabric isolation
asic0
  Local Link    Auto Isolated    Manual Isolated    Isolated
------------  ---------------  -----------------  ----------
           0                0                  0           0
           1                0                  0           0
           2                0                  0           0
....
Add test for the new commands.
The test is failed now as it needs this sonic-net/sonic-swss#3089 merged in first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants